Fix undo resetting active display group #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly create undo state while 100% preserving same indices (probably unnecessary but I noticed that I was relying on ordered index) - Move getting displayId from displayGroup at start of restore undo method (like before) so it can get the position before the values are replaced and instance comparison is no longer possible. Without this change display group always resets on undo Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Wires77
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(probably unnecessary but I noticed that I was relying on ordered
index)
method (like before) so it can get the position before the values are
replaced and instance comparison is no longer possible. Without this
change display group always resets on undo
Signed-off-by: Tomas Slusny slusnucky@gmail.com
Steps to reproduce
This PR fixes the last part.