Fix Out of Memory crash in Items Tab #4530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
This approach blows away internal tables to each item, notably modLists. Luckily in every case I can think of, we end up reparsing items anyway, so that's why it ends up working out. I could be wrong about how that works for items, and I can't find any bugs around this solution anyway, so I'm willing to give it a shot.
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.itemsinItemsTab.luawas being copied recursively whenever an UndoState was created, storing way too much information and eventually crashing PoB entirely due to Out of Memory errors.Limiting that recursion to a certain depth fixes the problem, and doesn't seem to break anything (fingers crossed).
Fixes #3733, #4311.
Demo video: https://www.youtube.com/watch?v=F5ejSSiNgwA