Skip to content

Conversation

@Paliak
Copy link
Contributor

@Paliak Paliak commented Jul 3, 2022

Fixes #4265 .

Description of the problem being solved:

Currently reservation efficiency in the calcs tab shows the whole float value. I think a percentage rounded to two decimal places would be nicer.

Steps taken to verify a working solution:

-Check various aura setups

Link to a build that showcases this PR:

From issue:

eNrdXelz2ziW_zz6KziumqmkIjsEwDOTzJZ8u9tXLCfp9Id0gSRoMaZIhaR8ZKr_930PIClSl2kls7O7TndikcAD3oHfOwBSb__rYRxrdyLLozR5t0V29C1NJH4aRMnNu60P14fbztZ__bP39pIXo4twdxrFeOefvb-8lb9rsbgT8bstl21pBc9uRPGxIsX-AFITnhQjkSZn_GuaHaXBu63zNBFbmseTICqqT37M8_ycj8W7rU9R4Y-2NJ77Ign2ZtcPYjEWScHjKC-2tDGPkmHq34riKEunk3db9pZ2F4n7szSAtidnlxdX143Bo6Q5OEz-L28vY_4osmHBCy2Hv95tDUAG_Ebs8zH8DdR4PAVSxCAmMXcsh9Ct18s7DidCBHUHukMsw1nV9jotxBiu-pKZ62g8G0nfIY5FbJ0Saluma60icZmJgzAUfhHdib0sKvZGPPEbE2Y7-sqpbtL-bBoX0SSORDbrs6r98SJ5XV8jCx7vXw7rtky3mMl2iGFZIAhrfb-0mEluVcuTmyQqRHMI03Vtneg7rkUtgz3Rb84SXJ2auq7vUNekDnlqds8fdW8ax7C0mh1XcraXjr0oEcHg7qYxQWJZaKyuDRa4coKDTPCLUJnQFQ-iaT6zXXtVpzOe8L00n8mcmquankahaDVdycTBsFu7K1BDt5Y4zUuRAXQU3TrgZJ_VoRxhKPwU4Ok5YzynS4OPzQbboOfBcJMOGww0LGZIQvWVJnclvjVbAgyvarkvHmbNbHMNwVZL0125_pOGodN1BJstiWmunuFdWoBTfFo4Ej4Oji_rlratMxtcg2lZjmusHEEpABxdNObxGX-IxtMxoPE1vxWzURn8OEBL_aHrbGiGXZTqazyf_wZbnyR-w6HY6wh_SDKRi-yu4TLXDdHuUhpcF--CHa_ETZN7y96xjXXtT4XwR0cQWsA4ILxu67RuBfC7VlDYuCkoupbsEjk5-o7Vrcu8nJwd23UJtSxmm6axlkhbZgaYy7rWz5bYJ54FHaAlEdnN43AUibhDayndZpeWOdIug7S57jSvZ7N-cMfzJgZQAAy6nifVo8WOsVofIhYCugRiLgaz6epYMv2KkWT8zH6DbJxOGyjuuLqzlhPVocmIs3IlXo4e88iHIErGX1cimPot7LRW4ksdF5-ldzLAlqE55AQz8e24K8fdjSGhmBPBOpuL42f1GBQF92_30-BGPGuQ5_cYTicTQAI0ne7R-GGUgazzqOHBV7vSWeMLyJr2-GSm1tURK66yjvRnjefpu6vx-2ZUJBA_dx5krsf8SGR18D3iaT43zDYxOzSfH2O1NiAX6JQIXKb3QHKEmXf-vNYQJMxc48p5ZCL5_jhPv1vzTgMcJME0QxvtzMN8j07DDCQsyOz7NBo30Fr5wrevZTEDfzsZT9Ks0GKeFwPfT6dJcczzERi2Ry3XdWzDFQYXQRgahjC5R21dD8PQ8Qw3YB4TAHDY9UrweAzy3lMfcarcL8BRSFqU2NwNbcNzXd_mNAwCIqjJA8c2debqgRFS7lKPq7nt8djPJVsnyWRaaImsh4yj3P_Dm4Yhljy2gM1MFmwODg8P9q5PPh6Ukmh2yW-jOP4jmY49zOXVv1g5US2HQsKs5qdxzCe5CN5thTzOgXYEvw6x7xA8jF90ag8escyfu7SGqMDPItB-l8aY-neasqzLdGmJZY5ODcE4eCy6C-z6cSLQCvOuMivxukvr3bgre5dplIP_7MSgrHx0U4Pw-WOnlnWk1Kn1QSwGUYzeu5vUzmAhKMffrT344SzypkVHa5PJUKd5YC7QicFmcNtxdXRrWIZlnSZRBqNd2paurptRQkTUWW37IhRg7h2XvYQTldAqzK6A8a1ca7mWA3AfiXG--wiu8xDFOyuUSWc65gUYIrgArFlfpzUqn6oadjlYi8y7rSKbwsVAhHwa4_X3Ux5HxSN6qMbVkgTkdFo-Su8xBFNkEAJyUM3pqboziIuSAo5RDar4RzZkaVu5K_lZMoklVy1K_HgaQK5dBgf1hGPu4dhb2g3WwvfQZ73bSqIYC_nci1GOiok8TjEFE3wCUiba8B5DkbnxcCiczV_ewvxKAkdx6vGYzgZUzBJ3q9WA1OMgoRO03IwXoy3tm2L4RKKGlBjMVYzx85koeMAL_voEXHP-GmXyWs4Dfmv3lgKfY8hXvIJw0MNhplGNqSxKkfqfFO6xAOgq_r1SPUvjQiTDEYT6G8t2GY2uElZ9NdX59U9ja1_AUhxHCVfZ3oaMLafSlbV27__PRnQE0Cc2lnK7d1fpql7_n6UKMowwgtvlSYJB9sZGvJRMdytW3bWy_39K4iClO0zpfkDiTwl8F1LBoPS2G4t7kPk8gRBHEnu2tKvemur-8wDxMIYxPo2iycaMLVLoypTsqQ2n2Y34P2w-VH9KxqXpqLzrOi3zn2fLuw73VhDqKnYMV6f5zPn8jCVS17musfpznfEV9iQ7XPJMzamDda0h3JXfmoQ2nESZ0CSR_5S9VYHxD1nck-o4eJjEaQ6kB1mW3j-pCrOTKlYQXaaGmnYpQHO5ZmqKmiL582CtXCxK2vWxnuq0xcYrbz09rBx3Mci6v6YIaPdRMdJU7T7vLITOuHPFkxsRKPKyOvkDAlhNCzdlO3G_y2M8X8U11f-n61yh4mWWxlEosg0D_ZrhddRgUlYnlhURrU3l5-sZd7FEoPaLN9fwEipdkfYkyQFhn8deZ73uCx7Ej3XZbnMOVxDqbMCqvzZXQPyfdyW7aVrk_95UAyO0MfcilM8PBYgLRJ4TI9adf1q4UkVk0ywXF4ncWd88Glsk0pW5Y_FQpFN_9DPjebk7trmu2t07a6nsJqeBB4TwbO5wOh6niQguIVwteP5vgPpDnhciU97oBzS4lIw87tuFddm57b3_I2AQACSVRyb-ncmMTNr2eT76sYSxRQEmSJ6RMcq-_8cFTehTgh74_jTj_uMgCXDvMB_Ap41lfpkJP8o3qVbOev68gOVjVPAfcikLBLpyU3ecM5_yN7nTc50JoXGlVdmJllsn8KH5zABOkqINIAA8ltuD77b-Zeq2afdNW7eNP_v_IsTUzb5FiQUfmGE4cIvpuomfKDVInxnUoPAJT6SbfUIcy4VPJjOcPtNNHW8RyhzaN2xLNrSo6cA9xzCRvmET1wYizGHwiToUbhkG1f8EttMAt4Vshs0pITCyrsOIRHeo27cNw-hbDKbXN-FXu4_nut0-syxmIAmHwe-Ukr5FmG71qeky1oerFu1Tm-rwu0VdIgdjfcUYdXXDBc5xRoZl2k7fcZneJy4xdJiBDs2BitmnDoPLBrBqwU3TRfkgTyYjSMvVHROau4z2pRgsZkEnAoMSScsA4i7R4TpOiRDgFoRDTQLTAzn0GTNst2-AlIEnCg1Nx3WRDGEu8tqXUjJNA4fRHRcu2AQGcB3TAdIMJksYNfu27VjAvQ69KNVRiLapG8CfAaMym0A_F2dgmhbM0jRgIn1GQCF9AzgBETigzb5pEWLB744OaiImRXHrkpYFszEZcEnhAvBNHNvsK32aDoWulqmDLkDrwAOzTCBvmQ7wSm0Lpmg6cAF4R41KI3N1lAaoUZICnZjIu00to08cQ6d9ZUcERoYJMVSS44DAqWnDJIhlw_CgflCbYYMm-hRmYuCEgKwFt0F5wIlp6agHYqDZ2fBv3zAIjuzCB6DlMNJ3qY6SA5uBMcH-0HpsmLKlo36l2RtEXXEt1KMNBmbr0JCABcGkTTQNtSJgzn21pCgxwA4s0AfauM5gZRewVhsPA2E-5ldrk5VYfBBA8hWc42IoIezD1an85S-jopjkb16_vr-_35nwYpSG4iGKxY6fjl9PgAxAwLZErW0c6PUAfnZvzvbC3e9--Ntv-4AP58dX1zS7s46_Pnw7ypEpNomvve_f-O0FLLbf2SgLHkTgFkV4Ehm32UH4Mf_tlFrfUmNyFv1x5Xw3Lj5nn_duDy-ujVv97GGYR-zybuye_vJo3No6vcn9998vQRCJR9P7k5u9---f736LpnuT4vw2-3CwO9QFn5p3H2-j4c3u73fnv_-i20F8ozMTFHpwOP3D885PrUQ8Dj6e_HK6S_euxAF73J8esq_8zvh1u_j14m401if3N67x7b15enmwP3qk-_vHF0ffi-37q-2T-99uh-JgSLcLOjx4_1lcXmVf338MPg_5tZMcPnzn98Pvk9vLb_mV_v2P3y_8r-7UPT3zf4n9hD2kf5wcpZdJyn830u0itYrb24Gd_374wb7L7PT6bjDILvc_cxZ_9fTw2B8fXgyPgkF-NrrdNn67Gp2cXh5ZR193xcj_xXWGZlDcJsKB_lKRrytNvlUPauVKreUnCYDSEhDTIAQolGeh5ZnTJQ0R9mYNSeXzXjfIwwdwBD_NI6zxAW2gbzuBtif53-QEGvCogF_5AATURRcgncR6FyC5US6g9BgK8KULKHFFOYUFF6BchvIBCl4aPkD6KukklA9QgNx0AkptDS9QugzpBRQYKRhc5QYacK8wUnmBEkEZRaRkeuUEpItRPgPkD5JUoKvgWsF_5RbACSivoJxA6TmkW5hzAsq1LDqB0iuhE1DAr5yAcieVE0CjKp2AdBTKcqUXUK5J-gblBEzLMc31TkDh_AonIF2wctTKByjvPvMBlTvDSa31Afb_Qh_gf_K-fxoO8_eRcfOhqHxAEf7S8gGA7catdfErYD-7HH98BF9Q-oBg_yy0LP67LX2A_9vt--_H0fQ2P5Q-4OH2g_QB9JQObw4v7NOLeOYDWH5zONzLr2wrofnB9-z-IgIf8Gl4eke_6s4fv-hD8TWzv3LwAdvFiWskj_vgC0ofcC4O3NIHFLl-MCS7I_ABk_0x-IBR8DHg28Xj9wfwAdt7o1_AB2TisOUDTk3ruPQBg2-emXxOt8G3SR-QehewAkofkMx8wMnvOshBYvx0lN7_lv5-OT3UPw_3vj_MfMDtu_88_r99jZkC_nKeFkLe-_IwOATzNnu9Lw_7OqCd_uXhAIJ4pl8fn5wfDbXrC-304uJX7eLDtXZ4cfXFfvPF1l6EaaaN00xAkhqmuXaPR8i0YiS03ZMj7QyL5bci14pUG9ylUaDl5Rm2KJGNMKHV1IPSR9MoEC97PfJSqwbeT7Xzi2sY5Qb45MmjxoNABFqIO2GB2n4AwlyVLzSgOjj_rKWh9ggJLvThmTaJhC_yv2ovxAMfT2Kh_Z1P0vwfZNtsUnnZ0xZ-PqdTzeeJ5o-EfwtzjXLNe9TiNL3F3TheqEG-PNj64aGtz-0GaV_sIk3xueC-ZDNN4kdouwsIQxk-HAA8lQwAGTz3No1RNiDFXEOJYqeSZprkfVAyzADGFZCs7vR6dI2MLiN8uKmv7Y0gwdeA1mGa3e5oFzgFJIvnrSHdFONHbRQV2C3XOCgihz55Kudzj9WIvYuzy9OD64PTz9ru1cner4phvzoT-Nf6p9djS6YT3SRoFVUloC8JJwLUR3T9b0gHD2CA-mASfc0TPocZrJIn0oNZJqWuVTbe10AoIruPcqHmFgKFXE0e5CW5Q4YlrztaqeOeMT9ZUNaIw0hc80Bzcj8rxg1b6Awjkh1T8zgMUQ2Np6Z3NOiKY0C2DtLEZ__R7qqn_6UKcTZgQbE_jeWuwl_LGVTrrGVtv6WTkTLNXDsBwUywx-vzaVZM0ViAfw7CzASPQYseD2oj8XDIfs3R-cHHA1iZGo4Nt8czHZlL2IZW0LaS-S7P8AF_rSwufrF3tJNCC1KRJ2pqhXYPpiSHveePUqFolbeAObIZcNjrbf8HfiQezn6-PBzCj22fgjBOAbq0IR75vzgHjnu9k0Qt5gqITpTB3Ge4yxWk9wksgrFANftRGPk5CP2GZ1KrNS7aA78g20SXiplk6U35NBEY2TVYpFzFPIbFxLX7UQqocwfQlmqAXZHPwZej2ctJYOM3GiKusokhDg3WFvkSTt9oJ-Fs3eQC38AQo6GhCnIsJ36bCrC_TNzDFLH4lKt1hsCFwAvAI8r2Y1g-AZiLAgG5cvAuwE2WjuU1P82Aj0maSGaBRe0OkgOwM4nxFYCeA6sc4RsbIFbbS1Xeq5WAhTWNbjMUPkgHcRemLFfwDGzQXkEeaIpojIfgnL7jLC6nsbTRFwqwuFrRNyDEimkeYgkbqWH7EfwL7u6lGgmpVIhwK8REjsdjhJVpUkRqfMRNBR9yYug2lNfYkYppcmFsUwfZGIQKHcqOuSimEzVKJu7SGLEkS6cgbqa8jGQ2R0VL58YOrf1d9uXBgZ_Dw9lnxfvlNIvCR2RGVozRxqSdvVC6AymBnpXWpC7AZQKAvKq6y9NW5cmk2VLWXpTiqrX992_TtPjHgljVZWVXfS2-A9W9bNGfncBZRV2RQIJ7ACeBtptNK7qKogNTPuWoNhhYSZY4M1vIxARfAKKtHVHCdNVidijhMPWneYlpeGftFIfgyyZyWexlU5hEadTgXFse9jgFzFXVe7ntj8S0RWq7gM4yNpD4IW5u8kVZGqWytJ8rzRbJRWE8k_Wfoho1TL2e1UbTHvwjzzJVbUsJSdOWszsWsUgUvMBctDK0KIlIFXwCF1ithtkiKGEA8h7AKDnGc5SiSa00ZRgC9EPUguim_UTp_ph7bATmCpUkyKWAePfIIm52TIRS1NlgODz5iLHbSMST0lUDJt1ApKkWOwRxgEgvtDIYAIiaKHRRZPro1CUpGdzLUChIp15cxlpV4NwDrRRVLHuPLKv-b2QsClfBlcnLryAU9dAX8bgoj5HAtfsRut1sCqE1Pp-nvWt2kYakQv5ZtK8AFR_jzbUXctdGc2DMb1O4jpoBZf7YlDIZaf3YjKg-N6Ve05Fz7QrJX1WRIqqjmuJJBpOQd17J6WZC-nWYRt2nTexCsTCoWcjnaML8IRDIIY5UuYbAdYw8ygRJejHQOgQo4BHDSAR9dU3q_gZdpXKaFXkJrsr8cjDzAKI-dE_dDbvXu8DIX1KFWZQgY_VVwOKlEtdL5MV4J0D20CkWjxgGgxYWbw_yUXmvCnw1nitDxa1HTABPEojVA5HluBp3Ywzl38vg6UouX9QRPjtVE2-iTnWIQwXiFTBSox4R18oIfCkEaDVjIfdlpggs5TI0rsQ2qAk4fVhTKg-OHjDSR14OMbhRUyuT5NPIA4U9oq3JJM-H4ESm1BxVJIO-BDKXKrabIQLe0yJlLGC_hYw7M57kkbR1-DSft9bMMfoGI52V-VivklN9JK4G9frW2rOCjfb0oc5B2icSWjRVA_mIBGihHqT1REpj8Lkz_iUJJLLsTG1jBHUeRIZ5GMLfpCpax1S2INpHFRJXsTSvZ17vNaNL4DH4neBR7SrjkgJNxqUW0VZkuu_Vxo_G1wOzaEebjH6xpYFIOz7l3iMAEuJPEkg7kDWCxlvfYBVgNR-YfgRzG-TNqHaSQlewE3-UprmYuakJZgGhim4q19jrHYsSLGReDOxLCOGQwCgWZ0mGsjU5lSKLENtgcriFDZ5PjKVOXg8yVH4QgMXJJwDKNi0zHKDljfkEETQtcpzTDdaDZFVHuiUpSlTaWBSjNMDrMIli6oETStWqQ5owvwJuySwMSMalJHdq0FyyDhrtGmWK9lKSMb4M4Y3tU8x5X0TyQXighjoCmogDXGPbMMnbfrXqAlUmKOsLhryplgGQx_pAGoOSckmiSrJnbLzU1q3AV2uW4KvlC6rZa-3qlEZci8WZSa5aRMuOhc7Gf9mUUyWJmkEljUTloIYUCXil0MfC1HLYlS4NMO7l4ipdy6miNSqPqjVD7IozmOmr5WNCDqDU9eJze_qBAJmhb1YhgKyacYkiwJnC5ckEUoZZcPyy1wKfRexZm1316rUsfVm_EsYsLAckmeZA9I02G0g-5tmAtRY-qRdADs6vlb2fHxzsq1WGpAd7ex-uBnufUYmyaqgKc0vhtoyMm8j8SlsJwbBo_QawSJ6uuTeNuSYxVVmEVS6huepeFdAhw_k0BKNDp4oY3ccVPIedzqwIpi0C_1EayzwO2Y0SH8A6R-xqVPj-2ms47BpXIdoKkJE3MpOfx09MGs-kFYKAZFyyH-V-mgWYxRxDtFXIa-DZM_XKHqxFzogMizQb541xj1LAudMK9z4kESYtMDiwvV2XEWUvbQ9gJMAobHb9NoJp5COtdfUC-MiqQiPu-05at0tlXPGco931DqVaINGaZlI1WJTKFKyXGZe0mhmW9hsbADViq-pXVetSGgNgxFp6VXqQxaRtomuXatdKw-2JOnaReIz-QFoTjA1pAwxS7nCVzk2COvgpWYX8hJyrwDVWdVKMp2R0w28wtgJl_FX7e1z8g_Xmfirnq70YFqXKcHaQuv_l7etqt0QetPoYiXtALp75o2GR4TG872k6_vxua5s6zg4zXcuwdGbjkVB8sh0soDjjk_rIGTYuH4s3yqfiC17sR2ja8rH_6jAYNvwNqTJ3hziuYzFGHKreJPRWnjArj3zh70Ohzo2B8at33qnnPuTlxrP02FS-NqA89XfFMcB-o10Nrg56uzGuFG2YYrLf-xhlUQALWftF3Iu4p-xQO9l_oznCJ4QIjwWe75rCCymDXwixLJsK3bRNKzQdwyKO5elED0IW2Lowg8DyPT20hN-Ts5AyAGJG7wSy98iPMDHVe0T_W2Ntlj4qxQgbXwvbM5t3Fehr8o0mPWfVHeXhdtP7vEfsZqPyZQ9g91g6kPtkOLO2oGhbUGeDo5O93kEYTqUNHsBiSMAv4OswEA7yW5WVwSKI5Hppyo0Lxwsc1weZMIu7IBWXUQvPSlDuCdvyfOqygLsGs0LPJbZwXJc4JmG-H-pWYLbkZtNe-cKEN5B3KvO9Et_eaJbZFqgBIsvUExLaYIwHDCH38VGiIDTCWgItb0D-CdlIzwRVADf1RfRvGOydJDkGQPFjD8Afl-DJeDyFuECmKvL9K1WKSwgW3MEa5Zqe4hCwhmNRt1pGYS_NsukE6-W7MULhWkJcnliBj97jfMcVCmVLFYpvT8JZ70d3USI0fJZkps-zdF6VHh5X8F0aWKZjcc9j8LdvO6HlAp7akAQwbjCbhTzwbcKE7fq66-qhZ_iuQ7kdtFRpsVWq1NuqtKw1qlSzFVIemNpjAArBONwNZJaqzd6DqNiDNofgVee74paO7AzJ6FQsU9AxuDlYj6gXd4VaVBMgvaT7GY_GaztjA7FKfcYy9Q3wzW5JEfmicnLvpxGEg1GMwFHrUbocj8dpIprKZEQPXW67Ftd1nYduGDqhq3vc5Q4e8TA8zwB1hrYVWqHhc8MRAHWWr5sO4y5x3ZYyiblCmYTMAZ0xU2b5zi4NQwIQhFyzDTCTR7e10kKbylohI3OZjNT7AwHQKxH9wgPRls2lKLI21PuB7rvAvOEFgjHXDE03sIgZAtcAYC4n1A101-PUtUJi27puC4Aqzzd0bvgOEy3RGKsgi9pzonGaO8U3uKFdrUYlKWXQMr-QUbmGx83x5YgQTWXRregxdyZcdagNeZTPveRlDtmW58E6eVrL5HmYpd9hEocyQDxMo3qH7lRiP0y_JUid69QnoR8wHeCAmAEFsbGQhZZFjMCzQp_5JuehHhhgeGHoOS6zDNcmgaAON9qA4c4EqffKgx5vtKPt3YZQTdoUKum9omBUIE51wn1eYtrsfea9VwbBhnBDJDfFqDcIYIlCZATXTKbhSwhLv7xCXHZbXOcXV2eD094AY5sCdzL34qnX8ouO4wtP-D4sON0JmRM41LQCxwstFoiQOE4odJtwG4IMuOa7OoQROlwPXdvjPu0imyv805SO1ZYOhh21wcjdsWExTbTrEWDmCDhewarTZvXD-cn7Dwe9fYEnA66mOcgO6xaPWG9Eb9dgWlh-EBCq665vBcRhoU0DV3CHC9MTwnLxNajEIaHgtu6FOkRZsJ5snRmGrgsh2gZhN1eTYc0rnkrFyxcuauqtVbi2QM-6K4_olIc1qkDoFYQh8rrEHWhmqmKQfHuyDHV6r4i5nKa-41IZNVSvK61CsTKSky89w6QrV4QwyZYL_CLJYz7F-BNdg1G7Blisv4KXWiF_d6n8f-XpuEI5mYD1wOizKJ3m2mWMkY3iDIJPapa_7wLSlq8HBhcEprMDaNVUlw_BLof_XB_C21B3zDDwTTtkEPOS0DAtUwcX4gTC8CzCTdsPfArgSF3DpCykpK0us2mjDX_vtHHwmKMn1koj7lHW9Ap4nqhah69MXV_Q0XKJEX1J5H8N6R1wjtW7vOgdYhqS4abcuJYUWOpKSRGnV4bS0M5l1YclDe2WSAVzTBqYgUFJAEgXWqZtC8s0mON6InQY-BjiucLhjud5NAzwfx54EEEZwjTbMZRDly_77SvtqLXwDdaW8SviNp1N9ZJYTb4ytpYvlYi4Lx4g3ocxeq-YYS9dOq6xoId_-RkmzcGfFnl29kGW5WlH8eNkhCgKKbfIe8MRv4G0NNHUi0FmuqCUrtYFZU1dmDwwue8bdmDpDg8D4Xo-pHLU8CDuYb4hBKR1HKIA0JBumh5kI45ucW4Tz_YARtq6IC0_Xytjd3sX_j9qorCxgTKkO5Jidmcos1_vy5WVwN4rZ1EV8n3WWLYUYKg7pkrbMOhSaDNTFaEr88wViqLLPcEjlzn0Pr9PegBFd4_aroiLpuh1Cv7d9G0IKR2fcdMMdcgUTAMcAcC8MA1IsV1BTQg3DcMBN8GF64SGbnLLM0PHbiMLWxsBWC2__spZBI1XjEhgl-jS9BXlden9G9eJBPu1GK9xBHhwgXsjmW5I_xqBoapisixyYokJJlq094pkcFcSxUQ1lFU2dK941G9e-as0w5YsoePHCaQ4ka9d30dZ3BtCajuSHM956YD6glmuazESQIAG0CQYhsK673FhgLMGpxyE1DQNnTmhaWFQJwJODQj1II8I28pxGsph5rxynKUCfmXTRSUZrHkNszlQ5t-qvcFZiX9GJ0ftL9VsbfPVDGb10karFcURY6nVg4nHj1U4vAtrCHwKnvj99JiNc1DYzAG7K90KmeEYM_XVOOa6y8HmaLv-szI20nv_yvDtIG_0Hcf98wUx9W0IyF4u5l6zduafL5i-bbQbteFeNSV_vnpB9G1ivnxCL2ar4KWyEbls2sWYgweInbWjNBPyePdZGsgXm2hyNPyaJMfdKit75QnwxSbmVlnSWtGCbJUVkvJR0yWLyVi2mPhd6mtnYPdxjHWSgTyoNxhPY9FCOqr7IeQ8VgCxr-5YvrA5Y2ZgG5yEPAhxUTmQQlJwO8yjlqdbtvB1yJEc29CpsNpOxmwGTq0Eks5seoDnAjmCzCcsUBd4wBeXAmsCodyZPEkKsNroRshFZxotpCTWMnWrN9Zq6pW1sADthYVqtjy-rLrULqj0_biardXrruaEtoOHNbt4mnoueJUGzSUa_AhsCul1r0e4cQwxBb7teze9b-nP9i3f812Hc8PRPaFD3ho4oSNs2xduYIADg8TFoL7j-rYZeJx6us0Cm1g8cKnRDthgTa8I2LYhRoC_W3HCXJggIVFV7HEHRXbGsl96r-FD1ypEkCGb3RBr6SbaReCWb6dG89Z8iqxeYtYETH2GqPOV6mZCvQI86RJNqGL7XO19Tw34Rm6x9y4zEUYPb7QGJgHjig_JhupUNcPvdusNp2G7j02MP-fe9I_Mqa4LrS0Txphm2FbxeZhmqulMR3O1SrtDOf4V1sBWWT6GgjMK5ehPuPqlhZqDBz6OYMlVGSGWJHET-6myILcD37cszM0BiSDvC7lhBTokIJQx19cDE1I7LggToYC0h9tW4DmhZzoOD3SHtn0_RLrLa1_GXFmQtgS3P1VI0TPoD1UEib3E1iAXvpliuTXzR73aN2vyJT2zxM90VyZ-NmskftBupZO2W8mGZ7qW4whiGyHFZwKFEwaWrXuO6Zs-cy0shISBaVALJO5SB5CFuJxCfs3CwLHmEj9rZbKxfaS1CmJkHkXo08kGc5fIHf1FyevKuI213Hr1zSslzrT9iaw0IU35mvDa7zeAxu6c3Tvrgt3hBGuj1_fp9iXunZaHv95PIxiuBfQkCF3Pcn0j4K7vQDboQyru-7bvUN8ixGSQJ2JIDIGu6wRUFy4sEMPjlmGGwmK9TzyL0wycKsxrfrdv1fYGmRNZWaecz7Bn2Z_lLGB7K_-jqmRZE8jKFN1alvWYS2NjfYd1rWbJIPwH8kd3pTMANzTO0_W-QIL8UsRf_NBaBCtc07Ii0a8ZvmReHXqYm9RcYNZeZkq06_wjMVcVtqz1XuQiEdoxrBxcYfg1T5ra9c57VH-W87gDPjm-eYWVETJZmtc0H9cqH9Lq7UUFDyAOwVhJnTIA7IFxAVI_KqpvNFCMxnbYjj5_yW1e2ptmuInVU18nAtOu77DWKM9Id6y5-sq_SkbfsD_roOlIHiTI6qdG1F7qaXWgedmJr1Y6RCFrYnNZ03xmXu4kz1dr9tIEzKF8MqqpdtJ6VFBNYTZ58mejcpCV4a6mniTMJ3gEE3upU0VlrUGai9xGUt_tibMhdEaS_iSSZq9Eb-2FoW9b-kuVytXbVaU0IbKTmwyd8rSlC3TpLvYwSp6Kcw74TSyeDihlH8zZgR254ybfFsf-WAwNy7a7cL0Rgn7CjdxjwfEgEP0Df1aFP27bQvH7UDSz3hCtBYcGCjNA06yFR9hKdHgyMhrGafX9P7P329YPUVdfWiVbqUM21akc1UcRbjx3bTR7qDbVe5prqmSxDRYDGy1ot3HNWRe2SLN6oXtNVe9GtSGAjvNoPKDeUWK0McaSqZeqaLQizupW5Td1VE3tlS3JXEtrsaV89qI57pLZtd6jVrNhrCDWEKezjJZ8E2Y93JLJqwJKo001Unnea81Zr-YRr2XyQHFAyvOY55jdqhcKNIxKrwpEy0Q5141267a4uBbFseGMljHzxKxw2XXu8pz1v9ROl02QbSbtbiKhP6mbsdkkrc1G69htmTTJE-peZl1PaECh6HMHWmJX1ibjPGG_q1xLB8ps80VFNuHE2MwYyGamZzytn0V3u0S0z6W7zMA25HwDHFqMB56e3QYIyZ4SQu0en6nN5TLfyNzMTTp1WqKLAdUGEVUHts2NpUw3MFJrs3XGNrNt9nyjMzb3ChuYONlY-Oz5y3YxfN4kfn6Spx8IozqqeTFc76wjawOb3VxJP2BMXdF8aU7yjKSks26ekNyqhKYDAtGN5bshmnRX6GLe1YEf1kFSi9laZ0UYG4vL3MQtdlkxi4llZzt_Yk4rk9LXZVYq3zInn06SX9KcJmF0s_CVy5C5zn2FtpemseBJiXmLX9Is31hzku-meT77VudhlE3zJY39aV6k47M0aLSVjzQSR77xLH8jK4wx7vao5wt7vXNxr03kQ2zjujD9psesv6k3YQTNb21ujiXfDZNXXxww-_5oa9m88CVLWECV9StVCwye5r3upuql8ojCM3rJwYYjVG_QUdB7Vd_jqNh9rHdZqi8PWqTx9nWl6bev8bVoF2H1UrR_9v4blfNiZg==

Before screenshot:

beforepercentfix

After screenshot:

percentfix

@Nightblade
Copy link
Contributor

Code LGTM, but now I'm thinking the tooltip looks a bit strange because efficiency increases on the tree, but decreases in this tooltip... (i.e. higher=better on tree, lower=better on tooltip)

Thoughts anyone?

@Lothrik
Copy link
Contributor

Lothrik commented Jul 4, 2022

The three four "reservation multiplier" columns are somewhat inconsistent after this change:

(Edit: three -> four; I didn't get the MCM column Enlighten shows up under in that screenshot.)

Personally I'd prefer all three columns follow a x 00.00 format, with everything beyond that rounded — if only because that's how we display this type of information everywhere else and updating that for consistency sounds annoying.

@Nightblade
Copy link
Contributor

Sorry @Paliak it looks like I've lead you astray! I guess the changed lines should look something like this:

efficiency = values.efficiency ~= 0 and ("x " .. round(1 / (1 + values.efficiency / 100), 2)),

@Paliak
Copy link
Contributor Author

Paliak commented Jul 4, 2022

Looking at it now the percentage does look kind of weird when next to the other stats.

Should the value be rounded or truncated is the question. Looking through how all the other descriptions are generated it's either round(x,2) or s_format("x %.2f ", x) so rounding would be consistent with all the other stats.

Full float:
fullfloat

Rounded:
rounded

Truncated:
truncated

And i just noticed i mixed up truncated and rounded in the commit message.

…to two decimal places is more consistant with how other stats work.
@Paliak Paliak force-pushed the reservationformatting branch from ba7e947 to bbbb17e Compare July 4, 2022 13:07
@Lothrik
Copy link
Contributor

Lothrik commented Jul 4, 2022

It might be worth rounding to 3-4 digits instead of 2, as otherwise the final reservation is rather far off from the implied multiplication: 50 * 0.69 = 34.5 vs 50 * 0.6993 = 34.965 or 50 * 0.59 = 30 vs 50 * 0.5952 = 29.76.

@Paliak
Copy link
Contributor Author

Paliak commented Jul 4, 2022

True. Starting to wonder whether this should be a setting somewhere since no matter at how many digits it gets rounded/truncated to some information will be lost.
4digits

@LocalIdentity
Copy link
Contributor

@Paliak are you on the PoB dev discord? If not send me a message and I'll invite you LocalIdentity#9871

@QuickStick123 QuickStick123 added user-interface Changes that only affect the UI bug: accuracy Wording differences labels Jul 7, 2022
@LocalIdentity LocalIdentity merged commit 41737b1 into PathOfBuildingCommunity:dev Aug 8, 2022
@Paliak Paliak deleted the reservationformatting branch January 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: accuracy Wording differences user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calcs tab: Mana: Reserved: Efficiency: Probably shows too many fractional digits.

5 participants