-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Display reservation efficiency as percentage with two decimal places instead of a full float multiplier #4518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display reservation efficiency as percentage with two decimal places instead of a full float multiplier #4518
Conversation
|
Code LGTM, but now I'm thinking the tooltip looks a bit strange because efficiency increases on the tree, but decreases in this tooltip... (i.e. higher=better on tree, lower=better on tooltip) Thoughts anyone? |
|
Sorry @Paliak it looks like I've lead you astray! I guess the changed lines should look something like this: efficiency = values.efficiency ~= 0 and ("x " .. round(1 / (1 + values.efficiency / 100), 2)), |
|
Looking at it now the percentage does look kind of weird when next to the other stats. Should the value be rounded or truncated is the question. Looking through how all the other descriptions are generated it's either round(x,2) or s_format("x %.2f ", x) so rounding would be consistent with all the other stats. And i just noticed i mixed up truncated and rounded in the commit message. |
…to two decimal places is more consistant with how other stats work.
ba7e947 to
bbbb17e
Compare
|
It might be worth rounding to 3-4 digits instead of 2, as otherwise the final reservation is rather far off from the implied multiplication: |
|
@Paliak are you on the PoB dev discord? If not send me a message and I'll invite you LocalIdentity#9871 |





Fixes #4265 .
Description of the problem being solved:
Currently reservation efficiency in the calcs tab shows the whole float value. I think a percentage rounded to two decimal places would be nicer.
Steps taken to verify a working solution:
-Check various aura setups
Link to a build that showcases this PR:
From issue:
Before screenshot:
After screenshot: