Skip to content

Conversation

@Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Jun 24, 2022

Fixes #3172.

Description of the problem being solved:


At 100% reduced cooldown recovery rate, the cooldown for any given skill should be infinite. This is correct, and how things work in both PoB and in-game currently. If you go beyond 100% reduced cooldown recovery rate however, in PoB currently that results in massive negative cooldown values:

I fixed this by copying what PoE does: reduced cooldown recovery rate beyond 100% simply doesn't do anything further.


All warcry-related "average uptime" calculations were using the wrong duration multiplier. Specifically they were using the duration modifier stat when the actual skill duration was expected. This leads to things like Enduring Cry providing half it's expected buff effect:

I fixed this by replacing:

local full_duration = calcLib.mod(activeSkill.skillModList, activeSkill.skillCfg, "Duration", "PrimaryDuration", "SkillAndDamagingAilmentDuration", activeSkill.skillData.mineDurationAppliesToSkill and "MineDuration" or nil)

with:

local full_duration = calcSkillDuration(activeSkill.skillModList, activeSkill.skillCfg, activeSkill.skillData, env, enemyDB)

Link to a build that showcases this PR:

https://pastebin.com/aXkRvmM2

Before screenshot:

After screenshot:

@Lothrik Lothrik added the bug Something isn't working label Jun 24, 2022
@LocalIdentity LocalIdentity added the bug: accuracy Wording differences label Jul 2, 2022
@LocalIdentity LocalIdentity merged commit 634c8aa into PathOfBuildingCommunity:dev Jul 2, 2022
@Lothrik Lothrik deleted the fix-warcry-calcs branch July 11, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: accuracy Wording differences bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enduring Cry's Physical Damage Reduction Buff Not Calculating Correctly

2 participants