Fix warcry duration and cooldown calcs #4488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172.
Description of the problem being solved:
At 100% reduced cooldown recovery rate, the cooldown for any given skill should be infinite. This is correct, and how things work in both PoB and in-game currently. If you go beyond 100% reduced cooldown recovery rate however, in PoB currently that results in massive negative cooldown values:

I fixed this by copying what PoE does: reduced cooldown recovery rate beyond 100% simply doesn't do anything further.
All warcry-related "average uptime" calculations were using the wrong duration multiplier. Specifically they were using the duration modifier stat when the actual skill duration was expected. This leads to things like Enduring Cry providing half it's expected buff effect:

I fixed this by replacing:
with:
Link to a build that showcases this PR:
https://pastebin.com/aXkRvmM2
Before screenshot:
After screenshot: