Add new config options for Boss Skill Presets #4436
Conversation
There was a problem hiding this comment.
Looks good pending an export of the skill data. Would help keep the tooltip up-to-date. Putting the damage values in the tooltip doesn't make a lot of sense to me, though, since we're populating the boxes anyway.
One other thing I noticed that might want to get fixed here is that the values of the damage can go into the negatives on the config page
src/Classes/ConfigTab.lua
Outdated
| elseif type(v) == "boolean" then | ||
| child.attrib.boolean = tostring(v) |
There was a problem hiding this comment.
This probably doesn't make sense if only edit controls have placeholders
src/Classes/EditControl.lua
Outdated
| --if self.placeholder and (self.buf == '' or not self.buf) then | ||
| -- self:SetPlaceholder(self.placeholder) | ||
| --end |
| local enemyCritChance = env.configInput["enemyCritChance"] or env.configPlaceholder["enemyCritChance"] or 0 | ||
| local enemyCritDamage = env.configInput["enemyCritDamage"] or env.configPlaceholder["enemyCritDamage"] or 0 |
There was a problem hiding this comment.
because of order of initialization it will be nil for a first pass, but is instantly rebuilt so, no the value will never be zero but it errors due to nil value on initialization
| --survival time | ||
| do | ||
| local enemySkillTime = env.configInput.enemySpeed or 700 | ||
| local enemySkillTime = env.configInput.enemySpeed or env.configPlaceholder.enemySpeed or 700 |
There was a problem hiding this comment.
Again, not sure if this will ever get to the 700 value
src/Modules/ConfigOptions.lua
Outdated
| local defaultPen = "" | ||
| build.configTab.varControls['enemyLightningPen']:SetPlaceholder(defaultPen, true) | ||
| build.configTab.varControls['enemyColdPen']:SetPlaceholder(defaultPen, true) | ||
| build.configTab.varControls['enemyFirePen']:SetPlaceholder(defaultPen, true) |
There was a problem hiding this comment.
For these boss values we might want to set the actual input, as I imagine people will want to see the real values regardless of what they had in the box before.
…lso clean-up boss skill preset tooltip
src/Modules/ConfigOptions.lua
Outdated
| Shaper Ball: Allocating Cosmic Wounds increases the penetration to 40% and adds 2 projectiles | ||
| Shaper Slam: Cannot be Evaded. Allocating Cosmic Wounds doubles the damage and cannot be blocked or dodged | ||
| Maven Memory Game: Is three separate hits, and has a large DoT effect. Neither is taken into account here. |
There was a problem hiding this comment.
Based on feedback this should explicitly state that for EHP hits before death >=4 to survive
There was a problem hiding this comment.
A lot of discussion happened in Discord, but to summarize future work/concerns:
- Users will have to put a value in each box that has a placeholder, otherwise the placeholder will take effect
- A global config setting around enemyIsBoss is probably needed at this point, since "No" probably shouldn't be the default, and not everyone is doing exclusively the highest boss setting anymore
Wires77
changed the title
2 participants
extension of #4423 by Wires
from his:
This still misses those, but also I would like a reset button to remove user inputs from certain boss value fields,
and it would be nice if enemy corpse life also used presets
edit: a function to update values is both unneeded and complex