Fix Flesh and Stone + Maim Support stacking #3929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lothrik
changed the title
Wires77
reviewed
Jan 26, 2022
There was a problem hiding this comment.
This isn't the right approach. We don't want to introduce skill-specific logic in the calc functions if we can avoid it. The function if modLib.compareModParams(mod, destMod) then in mergeBuff is most likely returning false and not choosing the stronger maim. If we fix that, they'll no longer stack, though, so I'm not sure what the best solution is. We don't have preSkill function calls in CalcPerform, otherwise I'd say that would be the way to go.
Debuffs probably work this way in the general sense, but this is the only support interaction that it happens on, so the code should probably be changed to stack debuffs if they come from the same source
.. as checking the player's activeSkillList for every minion skill makes no sense and does absolutely nothing.
Lothrik
force-pushed
the
fix-flesh-and-stone-maim-stacking
branch
from
278ff70 to
cde2d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2861
Description of the problem being solved:
Flesh and Stone stacks with Maim Support, but only when they're linked together. Currently in PoB Maim Support will stack with Flesh and Stone regardless of what skill its linked to.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/9QTmEqmS