Affliction Charges (Olesya's Delight) "%#more effect of non-damaging ailments" not factoring in on calcs screen

[gggilovegroundeffects]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Having %#more effect of non-damaging ailments from infliction charges increase Current Shock in calcs screen (increase is correctly shown in "shock effect mod"

What is the actual behaviour/value?

%#more effect of non-damaging ailments from infliction charges have no effect on Current Shock

How to reproduce the issue

1. Select Witch with Elementalist Ascendancy and spec into Shaper of Storms
2. Equip any spell skill that hits (arc works)
3. Equip Olesya's Delight
4. Go to "Calcs" tab and note "Current Shock" number
5. Go to Configuration tab and check "Do you use Frenzy Charges?"
6. Go to "Calcs" tab and look at "Current Shock"

Build code

https://pastebin.com/Auj9CYBk

Screenshots

[Icemasta]

So I will drop what I've found so far by digging through the code and understanding the basic mechanics as to why, this is similar to this bug as well: #1907

The calculations for shocks are done in two parts. The first part is done in calcPerform, which calculates the more modifier to damage taken by monsters because of shock. This modifier only looks at global stuff, so specific things like Shaper of Storms which is conditional on the biggest damage chunk being lightning, or skill specific modifiers like Arc's, are never taken account in the shock damage multiplier.

The second part, the shock effect mod shown in calcs is related to the skill selected, the skill's modes and more modifier is lightning is highest damage now apply and properly show for Shock Effect Mod, but both don't interact with each other.

Because calcOffence, which generates many parameters that would need to be used in calcPerform to value shock properly, you end up in a chicken-egg situation.

So this leads to the situation where skill specific and more modifier don't apply, lightning and non-damage ailments are undervalued.

There are a couple possible solutions:

1. Add a line in Calc under Elemental Ailment displaying the "Shock if applied by this skill", the user could then transcribe this value to the shock value. It wouldn't be great, but it would at least work.
2. Add an option in Configuration to select the source of shock. This is probably the best way but would require quite a bit of change, but it would best reflect your damage for those particular mods.
3. Outright change shock value to be based on present skill Shaper of Storm's situation, this would apply all things like OP's, it's a bit like suggestion 1.

[Regisle]

To add to this from #4707,
A bug I encountered was that Affliction charges do not seem to apply to base shock/chill from elementalist, as they are added after its calculated ([added here](https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/ad39bdc61b752eca2d86ff3a28a97a35a1120b7a/src/Modules/CalcOffence.lua#L440-L450))