Push released SimpleGraphic artifacts to PoB repos#69
Merged
Wires77 merged 9 commits intoPathOfBuildingCommunity:masterfrom Jan 28, 2025
Merged
Push released SimpleGraphic artifacts to PoB repos#69Wires77 merged 9 commits intoPathOfBuildingCommunity:masterfrom
Wires77 merged 9 commits intoPathOfBuildingCommunity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not a hard task, downloading the SimpleGraphic artifacts and manually pushing them to each PoB repo is just one more thing that can be automated off of a release task list and ensures it's not forgotten.
I'm just using
taron the DLLs right now, but ideally we'd be using the same artifacts uploaded to the workflow run. I don't see a clean way of doing that without downloading the uploaded artifacts or doing the same steps internal to theupload-artifactaction. I do think it's important to keep all of the debug symbols though, so I may upgrade this to at least include those on the release as well.This PR goes hand-in-hand with these: PathOfBuildingCommunity/PathOfBuilding#8425