Update permissions for Linux #1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Linux user experience by ensuring executable files in the
runtime/directory have proper execute permissions when the repository is cloned. This eliminates the need for Linux users to manually runchmod +xafter cloning and prevents executable permission changes from appearing as unstaged modifications in Git, providing a cleaner development workflow.Changes Made
1. Updated
.gitattributesruntime/*.exe,runtime/Update.exe, andruntime/Path*of*Building-PoE2.exe2. Set executable permissions in Git repository
chmod +xto set executable permissions on local filesystemgit update-index --chmod=+xto make Git track the files as executable in repository metadataPath of Building-PoE2.exeandUpdate.exe)13beaa9fc3. Updated
CONTRIBUTING.mdTechnical Details
The improvement addresses:
The solution:
git update-index --chmod=+x.gitattributesto ensure consistent handling across platformsVerification
git ls-files --stage)Backward Compatibility
Improves: Linux user experience by eliminating manual
chmod +xrequirement and preventing permission-related unstaged changes in GitPlatforms: Primarily benefits Linux users, no impact on Windows