Fix Dauntless max damage stacking #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1013 .
Description of the problem being solved:
Dauntless had a GlobalEffect "Buff" for the multiplier. Because of that, it stacked per skill. The issue linked used a crossbow skill which has 2 parts, Load Fragmentation Rounds and Fragmentation Rounds. If you add another skill like Arc with dauntless supporting it, it will further increase the maximum buff for all skills. Removing GlobalEffect makes it just apply locally, and still shows up in the breakdown for more damage. It just doesn't show in the Aura and Buff skills, which it probably shouldn't anyway.
Before screenshot: