Skip to content

Change Matrix4f and Matrix4x3f parameter types to Matrix4fc and Matrix4x3fc #223

@Kouvali

Description

@Kouvali

The setTransformation and setTranslation methods currently accept parameters of type Matrix4f and Matrix4x3f, respectively. However, it appears that changing these parameter types to Matrix4fc and Matrix4x3fc would work equally well.

In my use case, I often declare matrices as constants using the Matrix4fc interface to ensure immutability. This proposed change would be particularly useful in such scenarios, as downcasting is not safe and creating a new Matrix4f instance incurs unnecessary overhead.

public void setTransformation(Matrix4fc matrix) { /* ... */ }

public void setTransformation(Matrix4x3fc matrix) { /* ... */ }

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions