Convert all cbool occurrences to Boolean #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On x86_64 Linux, FPC's ctypes.cbool type is 4 bytes in size, whereas C99 _Bool and C23 bool types are 1 byte long. This causes mismatched struct sizes and field alignments between C and Pascal code. According to FPC developers, ctypes.cbool type is intended to replicate the behaviour of using 'int' for storing boolean values in C code, and not to be an equivalent of C99 _Bool / C23 bool. In the latter case, plain Pascal Boolean is recommended. See: https://gitlab.com/freepascal.org/fpc/source/-/issues/40746
suve
commented
May 28, 2025
Comment on lines
+302
to
+303
| function SDL_SetBooleanProperty(props: TSDL_PropertiesID; name: PAnsiChar; value: Boolean): Boolean; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_SetBooleanProperty' {$ENDIF} {$ENDIF}; |
There was a problem hiding this comment.
An additional bugfix made along the way - the SDL_SetBooleanProperty function was named SDL_SecboolProperty in our code. Looks like a victim of a search & replace.
|
Great, I would like to suggest (as done in #26 ) to use a different type name instead of If you disagree with the idea, please don't hesitate to merge this PR :). I approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #26, this PR replaces all occurrences of
cboolwithBooleanto fix struct size mismatch between C headers and our Pascal units.