Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: typo in README's Features section for fee percentages #78

Open
almndbtr opened this issue Feb 22, 2022 · 0 comments · May be fixed by #79
Open

Docs: typo in README's Features section for fee percentages #78

almndbtr opened this issue Feb 22, 2022 · 0 comments · May be fixed by #79

Comments

@almndbtr
Copy link

Summary

In the README's Features section, it's written:

If a PartyBid wins the NFT, a 2.5 ETH fee and 2.5% of the fractional token supply is transferred to the PartyDAO multisig.

The 2.5 ETH took me by surprise -- I double-checked the About page says this about what happens when a party is victorious:

Fee: Only on successful purchases by Parties, PartyBid charges a fee of 2.5% of both the ETH used in the purchase and the resulting tokens.

I'm interested in cutting a PR to resolve this ✌️
almndbtr added a commit to almndbtr/partybid that referenced this issue Feb 22, 2022
@almndbtr
fix(docs): clarify percentages upon victory
f313f3f 
## Summary

Closes PartyDAO#78

This updates the copy for a winning PartyBid.
@almndbtr almndbtr linked a pull request Feb 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): clarify percentages upon victory almndbtr/partybid
1 participant
@almndbtr