feat(distributor): add reentrancy guard #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merklejerk
approved these changes
Sep 22, 2022
| @@ -379,13 +379,16 @@ contract TokenDistributor is ITokenDistributor { | |||
| { | |||
| bytes32 balanceId = _getBalanceId(tokenType, token); | |||
| // Reduce stored token balance. | |||
| _storedBalances[balanceId] -= amount; | |||
| uint256 storedBalance = _storedBalances[balanceId] - amount; | |||
| // Temporarily set to max as a reentrancy guard. | |||
There was a problem hiding this comment.
Can we explain how this works and what attack it's preventing?
| distributor = _distributor; | ||
| } | ||
|
|
||
| function transfer(address to, uint256 amount) public virtual override returns (bool) { |
There was a problem hiding this comment.
Can we comment that this sequence of operations mimics ERC777?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: TokenDistributor: ERC777 tokensToSend hook can be exploited to drain contract