Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crowdfund): support claiming unreceived NFT and refunds #126

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Sep 21, 2022

If a refund or governance NFT cannot be received by the contributor from burn(), the crowdfund contract will take escrow of it. The contributor can come claim it later on using claim() to receive back their NFT and/or refund at a receiver address.

Related Issue: Calling transferEth function can revert if receiver input corresponds to a contract that is unable to receive ETH through its receive or fallback function

@height
Copy link

height bot commented Sep 21, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

contracts/crowdfund/Crowdfund.sol Show resolved Hide resolved
contracts/crowdfund/Crowdfund.sol Show resolved Hide resolved
sol-tests/crowdfund/Crowdfund.t.sol Show resolved Hide resolved
contracts/crowdfund/Crowdfund.sol Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants