Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP v4 (for core v8) documentation and samples #5136

Merged
merged 12 commits into from
Nov 25, 2020
Merged

ASP v4 (for core v8) documentation and samples #5136

merged 12 commits into from
Nov 25, 2020

Conversation

danielmarbach
Copy link
Contributor

No description provided.

@lailabougria lailabougria changed the title ASP v4 samples ASP v4 (for core v8) documentation and samples Nov 24, 2020
Copy link
Contributor

@SeanFeldman SeanFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new nuget alias is ASTP. But the samples, shouldn't those still be targeting ASP as the component name?

System.NullReferenceException : Object reference not set to an instance of an object. 1) Component metadata for component name 'ASTP' was not found.

@danielmarbach
Copy link
Contributor Author

@SeanFeldman The problem was that the prerelease verification tests did not deal with nuget aliases properly. I did a first attempt to solve it although the logic is not 100% bulletproof due to FirstOrDefault but it seems to catch what we currently have in docs

@danielmarbach danielmarbach merged commit f4d0ad3 into master Nov 25, 2020
@danielmarbach danielmarbach deleted the aspv4 branch November 25, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants