Addressing issues with failing flaky tests #2630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
force-pushed
the
john/flaky
branch
from
b77a723 to
02dec82
Compare
ngallegos
force-pushed
the
john/flaky
branch
from
42de1fd to
02dec82
Compare
This is to fix the flaky test failures that cause: Error: ReferenceError: window is not defined ❯ stopTimer src/composables/autoRefresh.ts:12:7 ❯ startTimer src/composables/autoRefresh.ts:20:5 ❯ executeAndResetTimer src/composables/autoRefresh.ts:31:7 ❯ Timeout._onTimeout src/composables/autoRefresh.ts:22:7 ❯ listOnTimeout node:internal/timers:588:17 ❯ processTimers node:internal/timers:523:7
Added run to vitest so by default we not running in watch mode
Otherwise the cleanup happens in a non deterministic order
johnsimons
changed the title
johnsimons
commented
Oct 7, 2025
| "lint": "eslint .", | ||
| "preview": "vite preview", | ||
| "test:component": "vitest ./src", | ||
| "test:component": "vitest run ./src", |
There was a problem hiding this comment.
By default vitest runs in watch mode, but in our CI we always want it to perform a single run without watch mode.
| "@testing-library/vue": "8.1.0", | ||
| "@tsconfig/node18": "18.2.4", | ||
| "@types/bootstrap": "5.2.10", | ||
| "@types/jsdom": "27.0.0", |
There was a problem hiding this comment.
We were missing this typescript type
Comment on lines
-36
to
-55
| function deleteAllCookies() { | ||
| const cookies = document.cookie.split(";"); | ||
|
|
||
| for (let i = 0; i < cookies.length; i++) { | ||
| const cookie = cookies[i]; | ||
| const eqPos = cookie.indexOf("="); | ||
| const name = eqPos > -1 ? cookie.substr(0, eqPos) : cookie; | ||
| document.cookie = name + "=;expires=Thu, 01 Jan 1970 00:00:00 GMT"; | ||
| } | ||
| } | ||
|
|
||
| afterEach(() => { | ||
| //Intentionally not calling mockServer.resetHandlers here to prevent ServicePulse in flight messages after app unmount to fail. | ||
| //mockServer.resetHandlers is being called instead in driver.ts | ||
|
|
||
| //Make JSDOM create a fresh document per each test run | ||
| jsdom.reconfigure({ url: "http://localhost:3000/" }); | ||
| localStorage.clear(); | ||
| sessionStorage.clear(); | ||
| deleteAllCookies(); |
There was a problem hiding this comment.
All this code was moved into the driver.ts
| deleteAllCookies(); | ||
| afterAll(() => { | ||
| console.log("Shutting down mock server"); | ||
| mockServer.close(); |
There was a problem hiding this comment.
We are cleaning up the mock server as per the documentation
| }, | ||
| test: { | ||
| pool: "forks", //https://github.com/vitest-dev/vitest/issues/2008#issuecomment-187106690 | ||
| pool: "forks", |
There was a problem hiding this comment.
forks is now the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue with the cleaning-up routines that can cause certain instances to be cleaned up before others.
We have started a discussion in vitest to figure out if the behaviour is a bug or if we are just using it incorrectly.
In the meantime, we have addressed the issue by refactoring the code to do the cleanup in a more consistent way.