ServicePulse doesn't indicate when a too-large audit body was not stored

[PhilBastian]

Symptoms

Messages with no body do not show any indicator that the body wasn't saved.

Who's affected

Users examining audited messages.

Root cause

If a message body is larger than ServiceControl/MaxBodySizeToStore then it is not persisted as part of auditing. This information is not presented in the UI.

Confirmed workarounds

None.

Original bug report

Describe the bug

Description

If a message body is larger than ServiceControl/MaxBodySizeToStore then it is not persisted as part of auditing. ServiceInsight displays this information to the user

ServicePulse does not display the same information, instead just showing a blank body

Expected behavior

An indication to the user that the message body was too large to be stored

Actual behavior

a blank body is displayed

Versions

Please list the version of the relevant packages or applications in which the bug exists.

Steps to reproduce

• send a message with a body exceeding ServiceControl/MaxBodySizeToStore to an endpoint that has auditing enabled.
• view the message in "All Messages" in ServicePulse. The body shows as blank with no indication why

Relevant log output

Additional Information

Workarounds

Possible solutions

Additional information

[ramonsmits]

The body can be empty/null, if that is the case I would expect a nice message instead of the current state as it feels like the UI is broken.

[afprtclr]

@ramonsmits Empty message just shows curly braces (see below). I'd say that is good enough.

[ramonsmits]

I personally would prefer a message stating something like "No message data available" as the UI still looks as if it isn't fully initialized.

Its also partially caused by the design to split the headers + body into separate tabs. On most systems it likely would be easily possible to show both simultaneously.

[afprtclr]

@ramonsmits This has been discussed internally and the conclusion was that showing curly braces is good enough.
The fix will be shipped with release 2.2.0.

[afprtclr]

Version 2.2.0 has been released. You can find it in our website or Docker Hub.

[udidahan]

The solution described of empty braces does not seem to communicate the reason described in this issue, "too-large audit body was not stored". There is no way for the user to know that the message wasn't empty to begin with, right?