Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NServiceBus.RabbitMQ 10.0.0 and use management client #4755

Draft
wants to merge 55 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
91e7846
Update the transport manifest
TravisNickels Jan 29, 2025
c2c8702
Use alpha version of RabbitMQ transport
TravisNickels Jan 29, 2025
0e51938
Update RabbitMQ manifest example
TravisNickels Jan 29, 2025
e3ef7fc
Check connection string to disable management API
TravisNickels Jan 29, 2025
e82975b
Change lock to semaphoreSlim
TravisNickels Jan 30, 2025
0c8d3f5
Update async/await for createConnection
TravisNickels Jan 30, 2025
440373c
Cleanup transport method call
TravisNickels Jan 30, 2025
580e37d
Update RabbitMQQuery with managementApiUrl for throughput
TravisNickels Feb 2, 2025
7647a52
Add functionality for RabbitMQ connection string management options
TravisNickels Feb 2, 2025
6f2ba91
Fix diagnostic log text
TravisNickels Feb 2, 2025
0bbbc2e
Add functionality for management options for direct routing
TravisNickels Feb 2, 2025
3fb0c26
Allow RabbitMQQuery to access the transport
TravisNickels Feb 4, 2025
58bfdf8
Update alpha version
TravisNickels Feb 4, 2025
cf5b8fa
Update transport creation with new API surface
TravisNickels Feb 4, 2025
ecc9d65
Remove connection string parsing
TravisNickels Feb 4, 2025
96bc0ca
Enable strong naming
TravisNickels Feb 7, 2025
1d5e78d
Change connection string option to ValidateDeliveryLimit
TravisNickels Feb 11, 2025
bd834e0
Make RabbitMQ transport internals visible to RabbitMQ transport tests
TravisNickels Feb 12, 2025
b8d2862
Remove disableManagementApi
TravisNickels Feb 12, 2025
f3cfef3
Update RabbitMQQuery to use the transport management client
TravisNickels Feb 12, 2025
c7b1ea6
Fix text
TravisNickels Feb 22, 2025
4795efa
Update API calls
TravisNickels Feb 26, 2025
6d528f6
Remove HttpClient and testing for it
TravisNickels Feb 26, 2025
f9d4c99
Comment out Vhost property for now
TravisNickels Feb 26, 2025
2c733e5
Update transport package
bording Feb 26, 2025
017fd5e
Get code compiling
bording Feb 26, 2025
fb19a02
Remove InternalsVisibleTo
bording Feb 26, 2025
646c157
Fix formatting error
bording Feb 26, 2025
31aa355
First pass cleanup
bording Feb 26, 2025
96aa8fe
Update to 10.0.0-beta.1
bording Feb 26, 2025
f6f6fbf
Improve how custom connection string settings are set
bording Feb 26, 2025
3fe50de
Change how ManagementClient gets passed in
bording Feb 26, 2025
d862f27
Wire up settings that apparently have been lost
bording Feb 26, 2025
93ee49d
Use classes from transport
bording Feb 26, 2025
96d96c1
Formatting
bording Feb 27, 2025
45396a1
Fix text for transport manifest
TravisNickels Feb 27, 2025
029f5db
Fix connection string examples
bording Feb 27, 2025
41b7651
Remove signing from TestHelper
bording Feb 27, 2025
4cf0aeb
Remove approval files for deleted tests
bording Feb 27, 2025
cb54872
Update QueueLengthProvider to use management client
bording Feb 27, 2025
8b2bb59
Get RabbitMQQuery tests working
bording Feb 27, 2025
a86011b
Remove unused parameter from RabbitMQQuery ctor
bording Feb 27, 2025
5dd9aa7
Get QueueLengthProvider tests working
bording Feb 28, 2025
122649f
Make IManagementClientProvider lazy to ensure endpoints have started
bording Feb 28, 2025
09b184c
Remove old settings
bording Mar 3, 2025
4a601d2
Reorder methods
bording Mar 3, 2025
c6bcbc2
Make GetPage private
bording Mar 3, 2025
4435198
Remove unneeded conversion to RabbitMQBrokerQueueDetails
bording Mar 3, 2025
09f6981
Remove GetPage
bording Mar 3, 2025
d8c26d3
Check for DisableStats in TestConnectionCore
bording Mar 3, 2025
32a9d68
Update to 10.0.0-beta.3
bording Mar 3, 2025
e5b39ce
Migrate RabbitMQ management API settings into connection string
abparticular Mar 4, 2025
08d99cd
Rename extension method
bording Mar 4, 2025
3d58e87
Improve names
bording Mar 4, 2025
9587913
Update to 10.0.0-beta.4
bording Mar 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename extension method
  • Loading branch information
bording committed Mar 7, 2025
commit 08d99cd8005317418bd486cb6c19089363ca158d
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ protected override RabbitMQTransport CreateTransport(TransportSettings transport

var transport = new RabbitMQTransport(RoutingTopology.Conventional(queueType), transportSettings.ConnectionString, enableDelayedDelivery: false);
transport.TransportTransactionMode = transport.GetSupportedTransactionModes().Contains(preferredTransactionMode) ? preferredTransactionMode : TransportTransactionMode.ReceiveOnly;
transport.SetCustomSettingsFromConnectionString(transportSettings.ConnectionString);
transport.ApplySettingsFromConnectionString(transportSettings.ConnectionString);

return transport;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ protected override RabbitMQTransport CreateTransport(TransportSettings transport

var transport = new RabbitMQTransport(RoutingTopology.Direct(queueType, routingKeyConvention: type => type.FullName.Replace(".", "-")), transportSettings.ConnectionString, enableDelayedDelivery: false);
transport.TransportTransactionMode = transport.GetSupportedTransactionModes().Contains(preferredTransactionMode) ? preferredTransactionMode : TransportTransactionMode.ReceiveOnly;
transport.SetCustomSettingsFromConnectionString(transportSettings.ConnectionString);
transport.ApplySettingsFromConnectionString(transportSettings.ConnectionString);

return transport;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

static class RabbitMQTransportExtensions
{
public static void SetCustomSettingsFromConnectionString(this RabbitMQTransport transport, string connectionString)
public static void ApplySettingsFromConnectionString(this RabbitMQTransport transport, string connectionString)
{
if (connectionString.StartsWith("amqp", StringComparison.OrdinalIgnoreCase))
{
Expand Down