Bump Microsoft.Data.SqlClient from 2.1.2 to 4.0.0 #2711
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
.NET
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/nuget/Microsoft.Data.SqlClient-4.0.0
branch
from
2fc9069 to
94512a8
Compare
Bumps [Microsoft.Data.SqlClient](https://github.com/dotnet/sqlclient) from 2.1.2 to 4.0.0. - [Release notes](https://github.com/dotnet/sqlclient/releases) - [Changelog](https://github.com/dotnet/SqlClient/blob/main/CHANGELOG.md) - [Commits](dotnet/SqlClient@v2.1.2...v4.0.0) --- updated-dependencies: - dependency-name: Microsoft.Data.SqlClient dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/nuget/Microsoft.Data.SqlClient-4.0.0
branch
from
94512a8 to
4921173
Compare
|
Microsoft.Data.SqlClinet version 3.0.1 has a breaking change that turns connection encryption on by default via. What this means to ServiceControl users is that after the upgrade the instance will fail to start for any user that wasn't using the encryption previously. This is likely to be the majority of our users. TL;DR; This should probably get out only in the next major. |
|
@tmasternak Can we detect that Encryption is not being used with a custom check and warn users that they should enable it? |
@mikeminutillo This should be possible. That being said I'm not sure what is the SC behavior when this (not being able to connect to the SQL instance) happens. Secondly, this is a breaking change for SqlT and SqlP as well which should probably be handled all at once (especially the communication part of things). |
|
@tmasternak I meant to do the custom check now, before applying this dependency update to give customers on the old version of the library the chance to enable encryption before we do anything. |
|
A newer version of Microsoft.Data.SqlClient exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Closing this issue so a new one can be re-created by dependabot. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/nuget/Microsoft.Data.SqlClient-4.0.0
branch
Do not merge see comment for more details
Bumps Microsoft.Data.SqlClient from 2.1.2 to 4.0.0.
Release notes
Sourced from Microsoft.Data.SqlClient's releases.
... (truncated)
Changelog
Sourced from Microsoft.Data.SqlClient's changelog.
... (truncated)
Commits
768b58bRelease notes v4.0.0 (#1389)c1b86b8update SqlClientLogger in refs (#1392)bca1b17new sni version (#1391)fe79b3dTest - Add tests for code coverage part2 (#1384)d1deaddTest - Add tests for code coverage part 1 (#1377)397279bAvoid throwing exception when receiving invalid SqlNotificationInfo value (#1...d853ac4Build script changes for enhanced testing experience (#1382)ab8ca76fix API docs(#1386)a5b357fTest | Code syntax improvements for TVP test (#1374)78e8ebcTests | Split up manual tests into sets (#1373)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)