Filter out null failedmessages #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBZA
requested review from
mikeminutillo,
danielmarbach,
boblangley and
SzymonPobiega
WilliamBZA
force-pushed
the
eventpublisher
branch
from
66a967c to
1708473
Compare
SzymonPobiega
approved these changes
Oct 19, 2018
danielmarbach
approved these changes
Oct 19, 2018
| @@ -27,10 +27,9 @@ protected override async Task<IEnumerable<object>> PublishEvents(IEnumerable<Dis | |||
| var failedMessages = new List<object>(failedMessageData.Length); | |||
| foreach (var entity in failedMessageData) | |||
| { | |||
| session.Advanced.Evict(entity); | |||
|
|
|||
| if (entity != null) | |||
There was a problem hiding this comment.
Another option would be to add a where clause to the list and then iterate over that but I prefer the if approach
There was a problem hiding this comment.
I had that originally, but then saw the if that was in the loop already and thought it looked neater than including the where in the loop above.
WilliamBZA
added a commit
that referenced
this pull request
Oct 19, 2018
* Bump zip dependency * Filter out null values
WilliamBZA
added a commit
that referenced
this pull request
Oct 19, 2018
WilliamBZA
added a commit
that referenced
this pull request
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1464
2 Commits. One to bump the zip package version (I can remove this?) and a second to filter out null failed messages.
I can't figure out how to force the expired documents to run in an acceptance test so am not sure how to add a test around this. Any suggestions?