Release 3.2.0

src/ServiceControl.AcceptanceTests/AcceptanceTest.cs

@@ -24,7 +24,7 @@ namespace ServiceBus.Management.AcceptanceTests
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
     [TestFixture]
-    public abstract class AcceptanceTest : IAcceptanceTestInfrastructureProvider
+    abstract class AcceptanceTest : IAcceptanceTestInfrastructureProvider
     {
         protected AcceptanceTest()
         {
@@ -271,7 +271,7 @@ void Log(string message, LogLevel messageSeverity)
         }
     }
 
-    public static class HttpExtensions
+    static class HttpExtensions
     {
         public static async Task Put<T>(this IAcceptanceTestInfrastructureProvider provider, string url, T payload = null, Func<HttpStatusCode, bool> requestHasFailed = null, string instanceName = Settings.DEFAULT_SERVICE_NAME) where T : class
         {

src/ServiceControl.AcceptanceTests/Audit/FailedAuditsModule.cs

@@ -13,7 +13,7 @@ public class FailedAuditsCountReponse
         public int Count { get; set; }
     }
 
-    public class FailedAuditsModule : BaseModule
+    class FailedAuditsModule : BaseModule
     {
         public FailedAuditsModule()
         {

src/ServiceControl.AcceptanceTests/Audit/When_a_message_fails_to_import.cs

@@ -13,7 +13,7 @@
     using ServiceControl.CompositeViews.Messages;
     using ServiceControl.Operations;
 
-    public class When_a_message_fails_to_import : AcceptanceTest
+    class When_a_message_fails_to_import : AcceptanceTest
     {
         [Test]
         public async Task It_can_be_reimported()

src/ServiceControl.AcceptanceTests/Audit/When_a_message_has_been_successfully_processed_from_sendonly.cs

@@ -12,7 +12,7 @@ namespace ServiceBus.Management.AcceptanceTests.Audit
     using ServiceControl.CompositeViews.Messages;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_a_message_has_been_successfully_processed_from_sendonly : AcceptanceTest
+    class When_a_message_has_been_successfully_processed_from_sendonly : AcceptanceTest
     {
         [Test]
         public async Task Should_import_messages_from_sendonly_endpoint()

src/ServiceControl.AcceptanceTests/Audit/When_a_message_sent_from_third_party_endpoint_with_missing_metadata.cs

@@ -12,7 +12,7 @@
     using ServiceControl.CompositeViews.Messages;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_a_message_sent_from_third_party_endpoint_with_missing_metadata : AcceptanceTest
+    class When_a_message_sent_from_third_party_endpoint_with_missing_metadata : AcceptanceTest
     {
         [Test]
         public async Task Null_TimeSent_should_not_be_cast_to_DateTimeMin()

src/ServiceControl.AcceptanceTests/Audit/When_message_successfully_processed.cs

@@ -13,7 +13,7 @@
     using ServiceControl.CompositeViews.Endpoints;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_message_successfully_processed : AcceptanceTest
+    class When_message_successfully_processed : AcceptanceTest
     {
         [Test]
         public async Task Should_list_the_endpoint_in_the_list_of_known_endpoints()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_is_imported.cs

@@ -15,7 +15,7 @@
     using ServiceControl.CompositeViews.Messages;
     using ServiceControl.Contracts.Operations;
 
-    public class When_processed_message_is_imported : AcceptanceTest
+    class When_processed_message_is_imported : AcceptanceTest
     {
         [Test]
         public async Task Should_be_accessible_via_the_rest_api()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_searched_by_debugsession.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class When_processed_message_searched_by_debugsession : AcceptanceTest
+    class When_processed_message_searched_by_debugsession : AcceptanceTest
     {
         [Test]
         public async Task Should_be_found()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_searched_by_messageBody.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class When_processed_message_searched_by_messageBody : AcceptanceTest
+    class When_processed_message_searched_by_messageBody : AcceptanceTest
     {
         [Test]
         public async Task Should_be_found_()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_searched_by_messageid.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class When_processed_message_searched_by_messageid : AcceptanceTest
+    class When_processed_message_searched_by_messageid : AcceptanceTest
     {
         [Test]
         public async Task Should_be_found()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_searched_by_messagetype.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class When_processed_message_searched_by_messagetype : AcceptanceTest
+    class When_processed_message_searched_by_messagetype : AcceptanceTest
     {
         [Test]
         public async Task Should_be_found()

src/ServiceControl.AcceptanceTests/Audit/When_processed_message_searched_by_msgid_for_endpoint.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class When_processed_message_searched_by_msgid_for_endpoint : AcceptanceTest
+    class When_processed_message_searched_by_msgid_for_endpoint : AcceptanceTest
     {
         [Test]
         public async Task Should_be_found()

src/ServiceControl.AcceptanceTests/CustomChecks/Custom_check_should_only_trigger_events_on_transition.cs

@@ -14,7 +14,7 @@
     using ServiceControl.EventLog;
 
     [TestFixture]
-    public class Custom_check_should_only_trigger_events_on_transition : AcceptanceTest
+    class Custom_check_should_only_trigger_events_on_transition : AcceptanceTest
     {
         [Test]
         public async Task Should_result_in_a_custom_check_failed_event()

src/ServiceControl.AcceptanceTests/CustomChecks/Custom_check_transition_should_trigger_signalr_event.cs

@@ -17,7 +17,7 @@
     using JsonSerializer = Newtonsoft.Json.JsonSerializer;
 
     [TestFixture]
-    public class Custom_check_transition_should_trigger_signalr_event : AcceptanceTest
+    class Custom_check_transition_should_trigger_signalr_event : AcceptanceTest
     {
         [Test]
         public async Task Should_result_in_a_custom_check_failed_event()

src/ServiceControl.AcceptanceTests/CustomChecks/When_a_custom_check_fails.cs

@@ -13,7 +13,7 @@
     using ServiceControl.EventLog;
 
     [TestFixture]
-    public class When_a_custom_check_fails : AcceptanceTest
+    class When_a_custom_check_fails : AcceptanceTest
     {
         [Test]
         public async Task Should_result_in_a_custom_check_failed_event()

src/ServiceControl.AcceptanceTests/CustomChecks/When_a_periodic_custom_check_fails.cs

@@ -19,7 +19,7 @@
     using JsonSerializer = Newtonsoft.Json.JsonSerializer;
 
     [TestFixture]
-    public class When_a_periodic_custom_check_fails : AcceptanceTest
+    class When_a_periodic_custom_check_fails : AcceptanceTest
     {
         [Test]
         public async Task Should_result_in_a_custom_check_failed_event()

src/ServiceControl.AcceptanceTests/ExternalIntegrations/When_a_message_has_custom_checks.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Contracts.Operations;
 
     [TestFixture]
-    public class When_a_message_has_custom_checks : AcceptanceTest
+    class When_a_message_has_custom_checks : AcceptanceTest
     {
         [Test]
         public async Task Notification_should_be_published_on_the_bus()

src/ServiceControl.AcceptanceTests/ExternalIntegrations/When_a_message_has_failed.cs

@@ -12,7 +12,7 @@
     using ServiceControl.Contracts;
 
     [TestFixture]
-    public class When_a_message_has_failed : AcceptanceTest
+    class When_a_message_has_failed : AcceptanceTest
     {
         [Test]
         public async Task Notification_should_be_published_on_the_bus()

src/ServiceControl.AcceptanceTests/ExternalIntegrations/When_encountered_an_error.cs

@@ -20,7 +20,7 @@ namespace ServiceBus.Management.AcceptanceTests.ExternalIntegrations
     /// The test simulates the heartbeat subsystem by publishing EndpointFailedToHeartbeat event.
     /// </summary>
     [TestFixture]
-    public class When_encountered_an_error : AcceptanceTest
+    class When_encountered_an_error : AcceptanceTest
     {
         [Test]
         public async Task Dispatched_thread_is_restarted()

src/ServiceControl.AcceptanceTests/ExternalIntegrations/When_heartbeat_is_restored.cs

@@ -15,7 +15,7 @@ namespace ServiceBus.Management.AcceptanceTests.ExternalIntegrations
     /// The test simulates the heartbeat subsystem by publishing EndpointHeartbeatRestored event.
     /// </summary>
     [TestFixture]
-    public class When_heartbeat_is_restored : AcceptanceTest
+    class When_heartbeat_is_restored : AcceptanceTest
     {
         [Test]
         public async Task Notification_is_published_on_a_bus()

src/ServiceControl.AcceptanceTests/ExternalIntegrations/When_heartbeat_loss_is_detected.cs

@@ -15,7 +15,7 @@ namespace ServiceBus.Management.AcceptanceTests.ExternalIntegrations
     /// The test simulates the heartbeat subsystem by publishing EndpointFailedToHeartbeat event.
     /// </summary>
     [TestFixture]
-    public class When_heartbeat_loss_is_detected : AcceptanceTest
+    class When_heartbeat_loss_is_detected : AcceptanceTest
     {
         [Test]
         public async Task Notification_is_published_on_a_bus()

src/ServiceControl.AcceptanceTests/HeartbeatMonitoring/When_an_endpoint_starts_up.cs

@@ -12,7 +12,7 @@
     using ServiceControl.Contracts.EndpointControl;
     using ServiceControl.EventLog;
 
-    public class When_an_endpoint_starts_up : AcceptanceTest
+    class When_an_endpoint_starts_up : AcceptanceTest
     {
         [Test]
         public async Task Should_result_in_a_startup_event()

src/ServiceControl.AcceptanceTests/HeartbeatMonitoring/When_an_endpoint_with_audit_enabled_without_heartbeat_plugin_starts_up.cs

@@ -10,7 +10,7 @@
     using ServiceControl.CompositeViews.Endpoints;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_an_endpoint_with_audit_enabled_without_heartbeat_plugin_starts_up : AcceptanceTest
+    class When_an_endpoint_with_audit_enabled_without_heartbeat_plugin_starts_up : AcceptanceTest
     {
         static string EndpointName => Conventions.EndpointNamingConvention(typeof(StartingEndpoint));
 

src/ServiceControl.AcceptanceTests/HeartbeatMonitoring/When_an_endpoint_with_heartbeat_plugin_starts_up.cs

@@ -11,7 +11,7 @@
     using ServiceControl.CompositeViews.Endpoints;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_an_endpoint_with_heartbeat_plugin_starts_up : AcceptanceTest
+    class When_an_endpoint_with_heartbeat_plugin_starts_up : AcceptanceTest
     {
         static string EndpointName => Conventions.EndpointNamingConvention(typeof(StartingEndpoint));
 

src/ServiceControl.AcceptanceTests/HeartbeatMonitoring/When_an_unmonitored_endpoint_is_marked_as_monitored.cs

@@ -12,7 +12,7 @@
     using ServiceControl.Monitoring;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_an_unmonitored_endpoint_is_marked_as_monitored : AcceptanceTest
+    class When_an_unmonitored_endpoint_is_marked_as_monitored : AcceptanceTest
     {
         static string EndpointName => Conventions.EndpointNamingConvention(typeof(MyEndpoint));
 

src/ServiceControl.AcceptanceTests/HeartbeatMonitoring/When_an_unmonitored_endpoint_starts_sending_heartbeats.cs

@@ -11,7 +11,7 @@
     using ServiceControl.CompositeViews.Endpoints;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_an_unmonitored_endpoint_starts_sending_heartbeats : AcceptanceTest
+    class When_an_unmonitored_endpoint_starts_sending_heartbeats : AcceptanceTest
     {
         static string EndpointName => Conventions.EndpointNamingConvention(typeof(MyEndpoint));
 

src/ServiceControl.AcceptanceTests/IAcceptanceTestInfrastructureProvider.cs

@@ -6,7 +6,7 @@ namespace ServiceBus.Management.AcceptanceTests
     using Infrastructure.Settings;
     using Newtonsoft.Json;
 
-    public interface IAcceptanceTestInfrastructureProvider
+    interface IAcceptanceTestInfrastructureProvider
     {
         Dictionary<string, HttpClient> HttpClients { get; }
 

src/ServiceControl.AcceptanceTests/MessageFailures/ErrorImportPerformanceTests.cs

@@ -10,7 +10,7 @@
     using NUnit.Framework;
     using ServiceControl.CompositeViews.Messages;
 
-    public class ErrorImportPerformanceTests : AcceptanceTest
+    class ErrorImportPerformanceTests : AcceptanceTest
     {
         [Test]
         public async Task Should_import_all_messages()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_SagaComplete_message_fails.cs

@@ -13,7 +13,7 @@
     using ServiceControl.MessageFailures.Api;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_a_SagaComplete_message_fails : AcceptanceTest
+    class When_a_SagaComplete_message_fails : AcceptanceTest
     {
         [Test]
         public async Task No_SagaType_Header_Is_Ok()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_failed_message_is_pending_retry.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_failed_message_is_pending_retry : AcceptanceTest
+    class When_a_failed_message_is_pending_retry : AcceptanceTest
     {
         [Test]
         public async Task Should_status_retryissued_after_retry_is_sent()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_invalid_id_is_sent_to_retry.cs

@@ -9,7 +9,7 @@
     using NUnit.Framework;
     using ServiceControl.Infrastructure;
 
-    public class When_a_invalid_id_is_sent_to_retry : AcceptanceTest
+    class When_a_invalid_id_is_sent_to_retry : AcceptanceTest
     {
         [Test]
         public async Task SubsequentBatchesShouldBeProcessed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_message_has_failed.cs

@@ -27,7 +27,7 @@
     using ServiceControl.MessageFailures.Api;
     using JsonSerializer = Newtonsoft.Json.JsonSerializer;
 
-    public class When_a_message_has_failed : AcceptanceTest
+    class When_a_message_has_failed : AcceptanceTest
     {
         [Test]
         public async Task Should_be_imported_and_accessible_via_the_rest_api()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_message_has_failed_from_send_only_endpoint.cs

@@ -11,7 +11,7 @@
     using NUnit.Framework;
     using ServiceControl.MessageFailures.Api;
 
-    public class When_a_message_has_failed_from_send_only_endpoint : AcceptanceTest
+    class When_a_message_has_failed_from_send_only_endpoint : AcceptanceTest
     {
         [Test]
         public async Task Should_be_listed_in_the_error_list_when_processing_endpoint_header_is_not_present()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_message_sent_from_third_party_endpoint_with_missing_metadata_failed.cs

@@ -13,7 +13,7 @@
     using ServiceControl.MessageFailures.Api;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_a_message_sent_from_third_party_endpoint_with_missing_metadata_failed : AcceptanceTest
+    class When_a_message_sent_from_third_party_endpoint_with_missing_metadata_failed : AcceptanceTest
     {
         [Test]
         public async Task Null_TimeSent_should_not_be_cast_to_DateTimeMin()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_pending_retry_is_resolved_by_queue_and_timeframe.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_pending_retry_is_resolved_by_queue_and_timeframe : AcceptanceTest
+    class When_a_pending_retry_is_resolved_by_queue_and_timeframe : AcceptanceTest
     {
         [Test]
         public async Task Should_succeed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_pending_retry_is_resolved_by_selection.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_pending_retry_is_resolved_by_selection : AcceptanceTest
+    class When_a_pending_retry_is_resolved_by_selection : AcceptanceTest
     {
         [Test]
         public async Task Should_succeed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_pending_retry_is_retried_again.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_pending_retry_is_retried_again : AcceptanceTest
+    class When_a_pending_retry_is_retried_again : AcceptanceTest
     {
         [Test]
         public async Task Should_succeed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_pending_retry_is_retried_by_queue_and_timeframe.cs

@@ -11,7 +11,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_pending_retry_is_retried_by_queue_and_timeframe : AcceptanceTest
+    class When_a_pending_retry_is_retried_by_queue_and_timeframe : AcceptanceTest
     {
         [Test]
         public async Task Should_succeed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_retry_fails_to_be_sent.cs

@@ -16,7 +16,7 @@
     using ServiceControl.Operations.BodyStorage;
     using ServiceControl.Recoverability;
 
-    public class When_a_retry_fails_to_be_sent : AcceptanceTest
+    class When_a_retry_fails_to_be_sent : AcceptanceTest
     {
         [Test]
         public async Task SubsequentBatchesShouldBeProcessed()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_retry_for_a_empty_body_message_is_successful.cs

@@ -14,7 +14,7 @@
     using ServiceControl.MessageFailures;
     using Conventions = NServiceBus.AcceptanceTesting.Customization.Conventions;
 
-    public class When_a_retry_for_a_empty_body_message_is_successful : AcceptanceTest
+    class When_a_retry_for_a_empty_body_message_is_successful : AcceptanceTest
     {
         [Test]
         public async Task Should_show_up_as_resolved_when_doing_a_single_retry()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_retry_for_a_failed_message_fails.cs

@@ -10,7 +10,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_retry_for_a_failed_message_fails : AcceptanceTest
+    class When_a_retry_for_a_failed_message_fails : AcceptanceTest
     {
         [Test]
         public async Task It_should_be_marked_as_unresolved()

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_retry_for_a_failed_message_is_successful.cs

@@ -15,7 +15,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_a_retry_for_a_failed_message_is_successful : AcceptanceTest
+    class When_a_retry_for_a_failed_message_is_successful : AcceptanceTest
     {
         [Test]
         public async Task Should_show_up_as_resolved_when_doing_a_single_retry()

src/ServiceControl.AcceptanceTests/MessageFailures/When_all_messages_are_retried.cs

@@ -10,7 +10,7 @@
     using ServiceControl.Infrastructure;
     using ServiceControl.MessageFailures;
 
-    public class When_all_messages_are_retried : AcceptanceTest
+    class When_all_messages_are_retried : AcceptanceTest
     {
         [Test]
         public async Task Only_unresolved_issues_should_be_retried()