Fix serialization of saga data #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saratry
approved these changes
Sep 18, 2024
DavidBoike
added a commit
that referenced
this pull request
Sep 18, 2024
* Failing test * Instruct serializer to use actual type of serialized saga data
DavidBoike
added a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptoms
Saga property changes are not reflected in ServiceInsight saga diagrams.
Who's affected
All users of NServiceBus.SagaAudit 5.0.0 are affected.
Root cause
A change of JSON serializer in version 5.0.0 from SimpleJson to System.Text.Json caused saga data properties to not be serialized. By default, System.Text.Json will only serialize properties of the compilation-identified type, meaning only properties of
IContainSagaDatawere serialized. This prevented any business-related properties on the type inheriting fromContainSagaDatabeing included.