implement IPersistTimeoutsV2 interface #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weralabaj
changed the title
|
@mauroservienti @DavidBoike @danielmarbach Could you have a look? |
|
Actual code looks fine to me. But (I'm sure this is just my own lack of context) why the references to NServiceBus.5.2.8-beta0001? |
|
@DavidBoike This is because we have dependency on fixes we need to do in core at the same time. We manually uploaded package to myget, but once the actual release is done I'll change it to the correct version. |
weralabaj
force-pushed
the
hotfix-2.2.2
branch
2 times, most recently
from
d0aa78a
to
80b8ce7
Compare
|
Makes sense. I'm 👍 (On all the others too, since they're all basically the same.) |
weralabaj
force-pushed
the
hotfix-2.2.2
branch
from
80b8ce7
to
fd2242f
Compare
| try | ||
| { | ||
| CoreTimeoutData timeoutData; | ||
| return TryRemove(timeoutId, out timeoutData); |
There was a problem hiding this comment.
Remind me: Why don't we have that try catch for the concurrency ex? (in the original try remove)
|
Looks good! |
weralabaj
changed the title
timbussmann
changed the title
timbussmann
added a commit
that referenced
this pull request
Oct 9, 2015
implement IPersistTimeoutsV2 interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who's affected
You might be affected if you are using one of the following transport configurations:
and you are using timeouts or deferred messages (e.g.
Bus.Defer(...))Symptoms
When experiencing connectivity issues with the transport there's a chance that a due timeout/deferred message is lost. Therefore the message will never arrive.
What to do if you are affected
We highly recommend to update to the latest patch versions of your NServiceBus and optional persistence and transport packages. For more details see issue Particular/NServiceBus#2885.
Connects to Particular/NServiceBus#2885