Skip to content

Allow customization of the Outbox record mapping #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2016
Merged

Allow customization of the Outbox record mapping #234

merged 3 commits into from
Nov 21, 2016

Conversation

SzymonPobiega
Copy link
Member

@SzymonPobiega SzymonPobiega commented Oct 25, 2016 •
edited
Loading

Introduces the following API:

var p = b.UsePersistence<NHibernatePersistence>();
p.UseOutboxRecord<MyOutboxRecord,MyOutboxRecordMapping>();

Fixes #231

Plan of attack

@SzymonPobiega SzymonPobiega self-assigned this Oct 25, 2016
@SzymonPobiega
Copy link
Member Author

@Particular/nhibernate-persistence-maintainers please review.

@SzymonPobiega SzymonPobiega mentioned this pull request Oct 25, 2016
Closed
@HEskandari
Copy link
Contributor

@SzymonPobiega think it can be reviewed now ;)

@MarcinHoppe
Copy link
Contributor

I think updating the doco is missing from the PoA here.

@SzymonPobiega
Copy link
Member Author

@MarcinHoppe PoA updated. I'll work on doco now.

@SzymonPobiega
Copy link
Member Author

OK, I've added a WIP doco pull. This is now ready for review @MarcinHoppe @HEskandari

@MarcinHoppe
Copy link
Contributor

@SzymonPobiega Can we somehow enforce the constraints we documented about MessageId, Dispatched, and DispatchedAt columns?

@HEskandari
Copy link
Contributor

This LGTM. I'll review the doco separately.

@SimonCropp
Copy link
Contributor

anything else holding this up?

@SzymonPobiega SzymonPobiega mentioned this pull request Nov 17, 2016
Merged
@SzymonPobiega
Copy link
Member Author

@SimonCropp we have huge problems with flaky tests with NH. @MarcinHoppe are you OK with merging this one without the ATT passing?

@MarcinHoppe
Copy link
Contributor

👍 from me to merge as long as only "known suspects" are red 😁.

@SzymonPobiega SzymonPobiega merged commit e2da4e4 into develop Nov 21, 2016
@SzymonPobiega SzymonPobiega deleted the custom-outboxrecord-mapping branch November 21, 2016 08:19
@SzymonPobiega SzymonPobiega added this to the 7.1.0 milestone Nov 21, 2016
@SzymonPobiega SzymonPobiega changed the title Allows to customize the outbox record mapping Allow customization of the Outbox record mapping Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SzymonPobiega SzymonPobiega

Labels
Feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SzymonPobiega @HEskandari @MarcinHoppe @SimonCropp