Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement IPersistTimeoutsV2 interface #130

Merged
merged 9 commits into from
Oct 8, 2015
Merged

Conversation

timbussmann
Copy link
Contributor

Who's affected

You might be affected if you are using one of the following transport configurations:

  • RabbitMQ transport
  • Azure transport
  • MSMQ or SQL transport with distributed transactions (DTC) disabled.

and you are using timeouts or deferred messages (e.g. Bus.Defer(...))

Symptoms

When experiencing connectivity issues with the transport there's a chance that a due timeout/deferred message is lost. Therefore the message will never arrive.

What to do if you are affected

We highly recommend to update to the latest patch versions of your NServiceBus and optional persistence and transport packages. For more details see issue #2885

Connects to Particular/NServiceBus#2885

@timbussmann timbussmann added the Bug label Oct 7, 2015
@timbussmann timbussmann added this to the 6.1.3 milestone Oct 7, 2015
@timbussmann timbussmann changed the title implement IPersistTimeoutsV2 interface [WIP] implement IPersistTimeoutsV2 interface Oct 7, 2015
@timbussmann timbussmann changed the title [WIP] implement IPersistTimeoutsV2 interface implement IPersistTimeoutsV2 interface Oct 8, 2015
@timbussmann
Copy link
Contributor Author

@andreasohlund @SzymonPobiega please review

@SzymonPobiega
Copy link
Member

I am good!

var t1EnteredTx = new AutoResetEvent(false);
var t2EnteredTx = new AutoResetEvent(false);

var task1 = Task.Factory.StartNew(() =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Use Task.Run instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I think we already did that on ravendb, but not on NHibernate

andreasohlund added a commit that referenced this pull request Oct 8, 2015
implement IPersistTimeoutsV2 interface
@andreasohlund andreasohlund merged commit 7abf244 into support-6.1 Oct 8, 2015
@andreasohlund andreasohlund deleted the hotfix-6.1.3 branch October 8, 2015 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants