Add NUnit.Analyzers to test project

Particular · Dec 2, 2024 · e26100a · e26100a
1 parent 4490c4e
commit e26100a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 13 deletions.
diff --git a/src/AcceptanceTests/NServiceBus.ClaimCheck.AzureBlobStorage.AcceptanceTests.csproj b/src/AcceptanceTests/NServiceBus.ClaimCheck.AzureBlobStorage.AcceptanceTests.csproj
@@ -13,6 +13,7 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
     <PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.2.3" GeneratePathProperty="true" />
     <PackageReference Include="NUnit" Version="4.2.2" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.4.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
   </ItemGroup>
 

diff --git a/src/AcceptanceTests/When_using_claimcheck_with_client.cs b/src/AcceptanceTests/When_using_claimcheck_with_client.cs
@@ -4,11 +4,9 @@
     using System.Threading.Tasks;
     using AcceptanceTesting;
     using NServiceBus;
-    using NServiceBus.ClaimCheck;
     using NServiceBus.AcceptanceTests;
     using NServiceBus.AcceptanceTests.EndpointTemplates;
     using NUnit.Framework;
-    using NUnit.Framework.Legacy;
 
     public class When_using_claimcheck_with_client : NServiceBusAcceptanceTest
     {
@@ -27,7 +25,7 @@ public async Task Should_work()
                 .Done(c => c.MessageReceived)
                 .Run();
 
-            CollectionAssert.AreEqual(payloadToSend, context.PayloadReceived);
+            Assert.That(context.PayloadReceived, Is.EqualTo(payloadToSend).AsCollection);
         }
 
         public class Context : ScenarioContext

diff --git a/src/AcceptanceTests/When_using_claimcheck_with_connection_string.cs b/src/AcceptanceTests/When_using_claimcheck_with_connection_string.cs
@@ -4,11 +4,9 @@
     using System.Threading.Tasks;
     using AcceptanceTesting;
     using NServiceBus;
-    using NServiceBus.ClaimCheck;
     using NServiceBus.AcceptanceTests;
     using NServiceBus.AcceptanceTests.EndpointTemplates;
     using NUnit.Framework;
-    using NUnit.Framework.Legacy;
 
     public class When_using_claimcheck_with_connection_string : NServiceBusAcceptanceTest
     {
@@ -27,7 +25,7 @@ public async Task Should_work()
                 .Done(c => c.MessageReceived)
                 .Run();
 
-            CollectionAssert.AreEqual(payloadToSend, context.PayloadReceived);
+            Assert.That(context.PayloadReceived, Is.EqualTo(payloadToSend).AsCollection);
         }
 
         public class Context : ScenarioContext

diff --git a/src/AcceptanceTests/When_using_claimcheck_with_custom_provider.cs b/src/AcceptanceTests/When_using_claimcheck_with_custom_provider.cs
@@ -3,13 +3,11 @@
     using System;
     using System.Threading.Tasks;
     using AcceptanceTesting;
-    using NUnit.Framework;
     using Azure.Storage.Blobs;
     using Microsoft.Extensions.DependencyInjection;
-    using NServiceBus.ClaimCheck;
     using NServiceBus.AcceptanceTests;
     using NServiceBus.AcceptanceTests.EndpointTemplates;
-    using NUnit.Framework.Legacy;
+    using NUnit.Framework;
 
     public class When_using_claimcheck_with_custom_provider : NServiceBusAcceptanceTest
     {
@@ -28,7 +26,7 @@ public async Task Should_work()
                 .Run();
 
             Assert.That(context.ProviderWasCalled);
-            CollectionAssert.AreEqual(payloadToSend, context.PayloadReceived);
+            Assert.That(context.PayloadReceived, Is.EqualTo(payloadToSend).AsCollection);
         }
 
         public class Context : ScenarioContext

diff --git a/src/AcceptanceTests/When_using_claimcheck_with_expiry.cs b/src/AcceptanceTests/When_using_claimcheck_with_expiry.cs
@@ -4,11 +4,9 @@
     using System.Threading.Tasks;
     using AcceptanceTesting;
     using NServiceBus;
-    using NServiceBus.ClaimCheck;
     using NServiceBus.AcceptanceTests;
     using NServiceBus.AcceptanceTests.EndpointTemplates;
     using NUnit.Framework;
-    using NUnit.Framework.Legacy;
 
     public class When_using_claimcheck_with_expiry : NServiceBusAcceptanceTest
     {
@@ -27,7 +25,7 @@ public async Task Should_work()
                 .Done(c => c.MessageReceived)
                 .Run();
 
-            CollectionAssert.AreEqual(payloadToSend, context.PayloadReceived);
+            Assert.That(context.PayloadReceived, Is.EqualTo(payloadToSend).AsCollection);
         }
 
         public class Context : ScenarioContext