Skip to content

Commit

Permalink
Merge pull request #654 from Particular/use-new-databus-lib
Browse files Browse the repository at this point in the history
Use NServiceBus.ClaimCheck.DataBus library
  • Loading branch information
kentdr authored Aug 7, 2024
2 parents 70325a8 + 0d3d5ee commit a5c4d56
Show file tree
Hide file tree
Showing 14 changed files with 36 additions and 29 deletions.
3 changes: 3 additions & 0 deletions src/AcceptanceTests/ConfigureDatabusEndpoint.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
using System.Threading.Tasks;
using NServiceBus;
using NServiceBus.AcceptanceTesting.Support;
using NServiceBus.ClaimCheck.DataBus;
using NServiceBus.DataBus.AzureBlobStorage.AcceptanceTests;

using SystemJsonDataBusSerializer = NServiceBus.ClaimCheck.DataBus.SystemJsonDataBusSerializer;

public class ConfigureDatabusEndpoint : IConfigureEndpointTestExecution
{
public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings, PublisherMetadata publisherMetadata)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.1.0" GeneratePathProperty="true" />
<PackageReference Include="NServiceBus.ClaimCheck.DataBus" Version="1.0.1" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
</ItemGroup>
Expand Down
6 changes: 4 additions & 2 deletions src/AcceptanceTests/When_using_databus_with_client.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
using NServiceBus;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using NServiceBus.ClaimCheck.DataBus;
using NUnit.Framework;
using SystemJsonDataBusSerializer = NServiceBus.ClaimCheck.DataBus.SystemJsonDataBusSerializer;

public class When_using_databus_with_client : NServiceBusAcceptanceTest
{
Expand All @@ -20,7 +22,7 @@ public async Task Should_work()
.WithEndpoint<EndpointWithCustomClient>(b => b.When(session =>
session.SendLocal(new MyMessageWithLargePayload
{
Payload = new DataBusProperty<byte[]>(payloadToSend)
Payload = new ClaimCheck.DataBus.DataBusProperty<byte[]>(payloadToSend)
})))
.Done(c => c.MessageReceived)
.Run();
Expand Down Expand Up @@ -64,7 +66,7 @@ public Task Handle(MyMessageWithLargePayload message, IMessageHandlerContext con

public class MyMessageWithLargePayload : ICommand
{
public DataBusProperty<byte[]> Payload { get; set; }
public ClaimCheck.DataBus.DataBusProperty<byte[]> Payload { get; set; }
}
}
}
11 changes: 5 additions & 6 deletions src/AcceptanceTests/When_using_databus_with_connection_string.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
using NServiceBus;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using NServiceBus.ClaimCheck.DataBus;
using NUnit.Framework;
using SystemJsonDataBusSerializer = NServiceBus.ClaimCheck.DataBus.SystemJsonDataBusSerializer;

public class When_using_databus_with_connection_string : NServiceBusAcceptanceTest
{
Expand All @@ -18,10 +20,7 @@ public async Task Should_work()

var context = await Scenario.Define<Context>()
.WithEndpoint<EndpointWithDatabusUsingConnection>(b => b.When(session =>
session.SendLocal(new MyMessageWithLargePayload
{
Payload = new DataBusProperty<byte[]>(payloadToSend)
})))
session.SendLocal(new MyMessageWithLargePayload { Payload = new ClaimCheck.DataBus.DataBusProperty<byte[]>(payloadToSend) })))
.Done(c => c.MessageReceived)
.Run();

Expand Down Expand Up @@ -64,7 +63,7 @@ public Task Handle(MyMessageWithLargePayload message, IMessageHandlerContext con

public class MyMessageWithLargePayload : ICommand
{
public DataBusProperty<byte[]> Payload { get; set; }
public ClaimCheck.DataBus.DataBusProperty<byte[]> Payload { get; set; }
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using Microsoft.Extensions.DependencyInjection;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using NServiceBus.ClaimCheck.DataBus;

public class When_using_databus_with_custom_provider : NServiceBusAcceptanceTest
{
Expand Down
11 changes: 5 additions & 6 deletions src/AcceptanceTests/When_using_databus_with_expiry.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
using NServiceBus;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using NServiceBus.ClaimCheck.DataBus;
using NUnit.Framework;
using SystemJsonDataBusSerializer = NServiceBus.ClaimCheck.DataBus.SystemJsonDataBusSerializer;

public class When_using_databus_with_expiry : NServiceBusAcceptanceTest
{
Expand All @@ -18,10 +20,7 @@ public async Task Should_work()

var context = await Scenario.Define<Context>()
.WithEndpoint<EndpointReceivingMessageWithExpiry>(b => b.When(session =>
session.SendLocal(new MyMessageWithLargePayloadAndExpiry
{
Payload = new DataBusProperty<byte[]>(payloadToSend)
})))
session.SendLocal(new MyMessageWithLargePayloadAndExpiry { Payload = new ClaimCheck.DataBus.DataBusProperty<byte[]>(payloadToSend) })))
.Done(c => c.MessageReceived)
.Run();

Expand Down Expand Up @@ -66,7 +65,7 @@ public Task Handle(MyMessageWithLargePayloadAndExpiry message, IMessageHandlerCo
[TimeToBeReceived("00:00:30")]
public class MyMessageWithLargePayloadAndExpiry : ICommand
{
public DataBusProperty<byte[]> Payload { get; set; }
public ClaimCheck.DataBus.DataBusProperty<byte[]> Payload { get; set; }
}
}
}
}
2 changes: 1 addition & 1 deletion src/DataBus/AzureDataBus.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace NServiceBus
{
using System;
using DataBus;
using NServiceBus.ClaimCheck.DataBus;

/// <summary>
/// DataBus implementation that uses azure blob storage.
Expand Down
3 changes: 2 additions & 1 deletion src/DataBus/AzureDataBusPersistence.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ namespace NServiceBus.DataBus.AzureBlobStorage
using Azure.Storage.Blobs;
using Microsoft.Extensions.DependencyInjection;
using Features;
using ClaimCheck.DataBus;
using Config;

class AzureDataBusPersistence : Feature
{
public AzureDataBusPersistence()
{
DependsOn<DataBus>();
DependsOn<DataBusFeature>();
}

protected override void Setup(FeatureConfigurationContext context)
Expand Down
1 change: 1 addition & 0 deletions src/DataBus/BlobStorageDataBus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace NServiceBus.DataBus.AzureBlobStorage
using Azure.Storage;
using Azure.Storage.Blobs;
using Azure.Storage.Blobs.Models;
using ClaimCheck.DataBus;
using Logging;
using Microsoft.IO;

Expand Down
2 changes: 1 addition & 1 deletion src/DataBus/ConfigureAzureDataBus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Text.RegularExpressions;
using Azure.Storage.Blobs;
using Configuration.AdvancedExtensibility;
using DataBus;
using ClaimCheck.DataBus;
using DataBus.AzureBlobStorage;
using DataBus.AzureBlobStorage.Config;

Expand Down
2 changes: 1 addition & 1 deletion src/DataBus/NServiceBus.DataBus.AzureBlobStorage.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PackageReference Include="Azure.Storage.Blobs" Version="[12.19.1, 13.0.0)" />
<PackageReference Include="Fody" Version="6.8.0" PrivateAssets="All" />
<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.0" />
<PackageReference Include="NServiceBus" Version="[9.0.0, 10.0.0)" />
<PackageReference Include="NServiceBus.ClaimCheck.DataBus" Version="[1.0.0, 2.0.0)" />
<PackageReference Include="Obsolete.Fody" Version="5.3.0" PrivateAssets="All" />
<PackageReference Include="Particular.Packaging" Version="4.1.0" PrivateAssets="All" />
</ItemGroup>
Expand Down
16 changes: 8 additions & 8 deletions src/Tests/ApprovalFiles/APIApprovals.Approve.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@
[assembly: System.Runtime.InteropServices.ComVisible(false)]
namespace NServiceBus
{
public class AzureDataBus : NServiceBus.DataBus.DataBusDefinition
public class AzureDataBus : NServiceBus.ClaimCheck.DataBus.DataBusDefinition
{
public AzureDataBus() { }
protected override System.Type ProvidedByFeature() { }
}
public static class ConfigureAzureDataBus
{
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> BackOffInterval(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int backOffInterval) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> BasePath(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string basePath) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> ConnectionString(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string connectionString) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> Container(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string containerName) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> MaxRetries(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int maxRetries) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> NumberOfIOThreads(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int numberOfIOThreads) { }
public static NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> UseBlobServiceClient(this NServiceBus.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, Azure.Storage.Blobs.BlobServiceClient blobServiceClient) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> BackOffInterval(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int backOffInterval) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> BasePath(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string basePath) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> ConnectionString(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string connectionString) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> Container(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, string containerName) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> MaxRetries(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int maxRetries) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> NumberOfIOThreads(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, int numberOfIOThreads) { }
public static NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> UseBlobServiceClient(this NServiceBus.ClaimCheck.DataBus.DataBusExtensions<NServiceBus.AzureDataBus> config, Azure.Storage.Blobs.BlobServiceClient blobServiceClient) { }
}
}
namespace NServiceBus.DataBus.AzureBlobStorage
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/NServiceBus.DataBus.AzureBlobStorage.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<ItemGroup>
<PackageReference Include="Azure.Storage.Blobs" Version="12.19.1" />
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="NServiceBus" Version="9.1.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="NServiceBus.ClaimCheck.DataBus" Version="1.0.1" />
<PackageReference Include="NUnit" Version="4.1.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
<PackageReference Include="Particular.Approvals" Version="1.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/When_using_AzureDataBusGuard.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace NServiceBus.Azure.Tests.DataBus
{
using System;
using NServiceBus.DataBus;
using NServiceBus.ClaimCheck.DataBus;
using NUnit.Framework;
using Settings;

Expand Down

0 comments on commit a5c4d56

Please sign in to comment.