Track messages that successfully completed the message or error pipeline but failed to get acknowledged due to expired leases #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
lease-timeout-fix-r12
branch
from
ac85419
to
97c08b9
Compare
…ine but failed to get acknowledged due to expired leases (#1212) * Tests for the receive strategy * Make ACK throw a LeaseTimeoutException consistently * Add Bitfaster caching * Implement fix * Cleanup * Some explanations and better expressiveness * Cover additional scenario of ACK failing * Make sure we keep track of to be completed message ids * Cleanup exception * Keep track of QueueMessage * Better log statement * Add acceptance test for visibility expiry * Acceptance test to verify expiry * Fix incorrect log statement * Tone down immediate retry to debug since immediate retries is a common case that should cause warns * Exception cosmetics * Limit concurrency instead * Properly group dependencies * Evil whitespace has crept in * Let the exception bubble up Co-authored-by: Jayanthi <88632084+soujay@users.noreply.github.com> * Improve the log statements --------- Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com> Co-authored-by: Jayanthi <88632084+soujay@users.noreply.github.com> (cherry picked from commit 5872d55) (cherry picked from commit c32a694) (cherry picked from commit 78bb31a)
danielmarbach
force-pushed
the
lease-timeout-fix-r12
branch
from
97c08b9
to
cadd40e
Compare
danielmarbach
changed the title
This was referenced Sep 18, 2024
TravisNickels
approved these changes
Sep 18, 2024
soujay
changed the title
soujay
approved these changes
Sep 18, 2024
soujay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1212 to
release-12