Enable no-implicit-optional and fix the one error that occurs #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes from the benc-mypy branch. See mypy issue python/mypy#9091 for a bit more discussion about this option.
benclifford
added a commit
that referenced
this pull request
Jan 19, 2023
no_implicit_optional was turned on for the whole tree in PR #2509 so does not need turning on for subtrees any more.
benclifford
added a commit
that referenced
this pull request
Jan 26, 2023
no_implicit_optional was turned on for the whole tree in PR #2509 so does not need turning on for subtrees any more.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the benc-mypy branch.
See mypy issue python/mypy#9091 for a bit more discussion about this option.
Type of change