Add regression test for VideoManager heartbeat crash
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertions are self explanatory and this makes the code cleaner while also removing the chance that the error messages will be out of sync with the expectation contents.
mokagio
force-pushed
the
mokagio/remove-video-force-unwrapping
branch
from
657e2cd to
a704373
Compare
mokagio
commented
Jun 6, 2023
| ) | ||
| parselyTracker.track.event(event: event) | ||
| os_log("Sent vheartbeat for video %s", log: OSLog.tracker, type:.debug, data.key) | ||
| curVideo._heartbeatsSent += 1 |
There was a problem hiding this comment.
This mutation is why we need curVideo to be a var.
mokagio
commented
Jun 6, 2023
Comment on lines
+184
to
+185
| // ...and verify that no crash has occurred by performing a simple assertion on the tracker state | ||
| expect(self.parselyTestTracker.eventQueue.list).to(beEmpty()) |
There was a problem hiding this comment.
I didn't write it in the comment (can add it if you think it would be useful) but of course if there's a crash this code won't run. The assertion is there just so that we can have something in the test.
crazytonyli
requested changes
Jun 7, 2023
Tests/VideoTests.swift
Outdated
| "A call to trackPause should not remove an accumulator from videoManager.accumulators") | ||
| let videoManager = VideoManager(trackerInstance: parselyTestTracker) | ||
|
|
||
| videoManager.trackPlay( |
There was a problem hiding this comment.
This line doesn't have the right indentation. Move one more level to the right?
There was a problem hiding this comment.
🤦♂️ there's something clashing between my VS Code and .vimrc and it's breaking formatting 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of the work done by @HelioMesquita in #83. Many thanks! 🙇♂️