Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tracing of all on generator expressions #215

Merged
merged 1 commit into from
May 29, 2021

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented May 29, 2021

Having conditions using all quantifiers is useful to catch bugs, but
it is very cumbersome to trace back what caused the all to fail.

This patch implements a tracing of the generator expression in all and
reports the first example in the comprehension which was falsy.

Having conditions using `all` quantifiers is useful to catch bugs, but
it is very cumbersome to trace back what caused the `all` to fail.

This patch implements a tracing of the generator expression in all and
reports the first example in the comprehension which was falsy.
@mristin mristin force-pushed the mristin/Added-tracing-of-all-on-violation branch from 48991b6 to 997e501 Compare May 29, 2021 21:43
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 93.81% when pulling 997e501 on mristin/Added-tracing-of-all-on-violation into 463c729 on master.

@mristin mristin merged commit bdd485a into master May 29, 2021
@mristin mristin deleted the mristin/Added-tracing-of-all-on-violation branch May 29, 2021 21:50
mristin added a commit that referenced this pull request May 29, 2021
* Fixed handling of `self` when passed as kwarg (#213)
* Added reporting of all arguments on violation (#214)
* Added tracing of `all` on generator expressions (#215)
@mristin mristin mentioned this pull request May 29, 2021
mristin added a commit that referenced this pull request May 29, 2021
* Fixed handling of `self` when passed as kwarg (#213)
* Added reporting of all arguments on violation (#214)
* Added tracing of `all` on generator expressions (#215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants