Fixed UI issues: non-resizable window, grey background, white buttons (#1) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In Windows, Tkinter colors work fine, but on macOS, the background colors are overwritten by the system theme. Therefore, I used a canvas to avoid this issue.
This pull request addresses and fixes the UI issues described in Issue #1 of the repository.
Changes made:
Non-Resizable Window:
Resolved the issue where the window's height was fixed. Users can now resize the window vertically to suit different screen sizes and preferences.
**Code change: **
root.resizable(width=True, height=True)Color Scheme and Button UI:
Improved the visibility of the calculator's buttons and background by adjusting the color scheme.
Implemented a more contrasting color scheme for better readability, using darker shades for buttons and background.
Expected Behavior:
The application window should now be resizable in both width and height.
Buttons and the background should have improved contrast for better visual appeal and readability.
Steps to Test:
Launch the calculator application.
Verify that the window can now be resized vertically.
Check the button color scheme and ensure readability and visual appeal have improved.
Light Mode Screenshot
Dark Mode Screenshot
Could you please review the pull request and approve or merge it?