Conversation
Collaborator
Author
|
Update: tests are currently failing on the remote, I'll look into this. |
j-atkins
force-pushed
the
drifter-increase-offset
branch
from
14eb76b to
48b8880
Compare
Collaborator
Author
Now fixed |
for more information, see https://pre-commit.ci
erikvansebille
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ammedd and I discussed previously that it would be good to increase the random noise applied to the drifter particle seeding locations to allow them to spread apart a bit more when multiple drifters are released from the same waypoint. Therefore, this PR arbitrarily increases the amount of offset via
_random_noisein utils.py.To see the effect, I have copied two images below showing drifter deployments (5 drifters per waypoints, 42 day lifetimes). 1) with the old offset and 2) with the new offset. I think it looks better now...
1) Old
2) New