Small bug fix in the create_release_map.py script. #30
Merged
michaeldenes merged 3 commits intomainfrom May 27, 2024
Merged
Conversation
…tude and longitude columns to work nicely with the particleset constructor.
erikvansebille
approved these changes
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 15.43% 15.43%
=======================================
Files 6 6
Lines 473 473
=======================================
Hits 73 73
Misses 400 400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fanqi203
pushed a commit
to fanqi203/plasticparcels
that referenced
this pull request
Jul 8, 2025
…ap_script Small bug fix in the create_release_map.py script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue #17 was raised where the fisheries dataset would have latitude and longitude column names 'ModelLatitude' and 'ModelLongitude', which would not work nicely with the
create_particleset_from_mapfunction. This PR adds the required line to rename the latitude and longitude columns.