-
Notifications
You must be signed in to change notification settings - Fork 166
Adding v4 Kernel loop explanation #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-dev
Are you sure you want to change the base?
Conversation
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this explanation_kernelloop also need to be linked in the index.md? I can't see it in the readthedocs now
|
|
||
| Instead, update the local variable `particles.dlon`. | ||
|
|
||
| ## Working with Status Codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to its own file/documentation? it doesn't have too much to do with the Kernel Loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the new notebook discussing statuscodes and will add it in a new PR
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com> Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
for more information, see https://pre-commit.ci
This PR builds on #2333, which updated the explanation of the Kernel loop. In my view, the Kernel loop tutorial should really be more of an explanation/background reading guide, which is why I have made it into a
.mdfile. I have updated the example code, including adding boolean logic for working with StatusCodes. Should we test these last Kernels somewhere?