Skip to content

Conversation

@nilodna
Copy link
Contributor

@nilodna nilodna commented Oct 2, 2025

Updating progress bar description to show the `integration time. fixes #2149

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why there is the need for the isinstance checks here as well as the second statement?

Is the second statement because this doesn't show on the first loop?

@nilodna
Copy link
Contributor Author

nilodna commented Oct 2, 2025

Just wondering why there is the need for the isinstance checks here as well as the second statement?

I wasn't sure where exactly in the code time is checked for datetime64/timedelta64, so I'm checking it. Going through the code right now I found where this check is done, so I'll delete this conditional statement.

Is the second statement because this doesn't show on the first loop?

Yes! It is just to initialize the progress bar with the same size.

@erikvansebille erikvansebille merged commit 65ea408 into Parcels-code:v4-dev Oct 2, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Parcels development Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use datetime64/timedelta64 for progressbar

3 participants