-
Notifications
You must be signed in to change notification settings - Fork 168
Require dt argument in ParticleSet.execute()
#2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require dt argument in ParticleSet.execute()
#2274
Conversation
|
Oops - forgot to run tests prior to PR. Needs some more work to make sure tests don't break. |
|
Okay, this one was a little more involved than it initially looked, but I think I have things working now. In order to keep allowing I personally think that requiring the |
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; also agree to make pyfunc a required argument too; this is what users would do anyways
Only one question below
|
Thanks for the contribution @andrew-s28 ! 🚀 |
Does what it says on the tin: removes the default 1s time step for
ParticleSet.execute()and now requires the user specify adtargument when calling the function.Addresses #2136 as a part of #2261. Happy hackathon :)