Update Kernel signature to (particles, fieldset) #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvansebille
changed the title
VeckoTheGecko
approved these changes
Sep 12, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good! I added f411b45 since this wasn't tested before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the function signatures of Kernels from
(particle, fieldset, time)to(particles, fieldset), as part of the vectorisation work in v4It also moves the
_assert_same_function_signature()function to thetooldirectory (not sure if the_helpers.pyfile is the best place), so it can be used for testing signatures of Interpolation and Kernel functionsmainfor v3 changes,v4-devfor v4 changes)