-
Notifications
You must be signed in to change notification settings - Fork 168
Update dark-theme docs #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dark-theme docs #1954
Conversation
Using the new Parcels logos from the oceanparcels website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I'm basing this PR on v3, but it should probably also be merged into v4?
Should we just merge straight into v4 instead of into both? I'm sure more visual tweaks will come up, and I think focusing on v4 would be simpler for these :) Just realised that the logos are included here. Yes, in that case let's update both branches. Just when merging choose "squash merge" so that its easy to apply the changes to the other branch
I agree that v4 should indeed be the most important target. I tried to change but then also get a lot of other commits... How do I most easily rebase(?) But I also think it's too nice to not also update for v3. Can't we just cherry-pick the commits in this PR and also merge them in |
Looks to be pydata/pydata-sphinx-theme#918 ? If you check out https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html#images-and-content-that-work-in-both-themes ? We might need to update our version of the theme. Will check |
Following suggestion in #1954 (comment)
Following suggestion in #1954 (comment)

Now that we have a nice new dark theme for ocean parcels.org (Parcels-code/parcels-code.org#141), it's time to also update the docs-page. This PR updates the logos and updates the homepage animation to have transparent background
I'm basing this PR on v3, but it should probably also be merged into v4?
mainfor v3 changes,v4-devfor v4 changes)