Skip to content

Conversation

@erikvansebille
Copy link
Member

Now that we have a nice new dark theme for ocean parcels.org (Parcels-code/parcels-code.org#141), it's time to also update the docs-page. This PR updates the logos and updates the homepage animation to have transparent background

I'm basing this PR on v3, but it should probably also be merged into v4?

  • Chose the correct base branch (main for v3 changes, v4-dev for v4 changes)

Using the new Parcels logos from the oceanparcels website
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I'm basing this PR on v3, but it should probably also be merged into v4?

Should we just merge straight into v4 instead of into both? I'm sure more visual tweaks will come up, and I think focusing on v4 would be simpler for these :) Just realised that the logos are included here. Yes, in that case let's update both branches. Just when merging choose "squash merge" so that its easy to apply the changes to the other branch

@erikvansebille erikvansebille changed the base branch from main to v4-dev April 3, 2025 08:46
@erikvansebille erikvansebille changed the base branch from v4-dev to main April 3, 2025 08:47
@erikvansebille
Copy link
Member Author

Should we just merge straight into v4 instead of into both? I'm sure more visual tweaks will come up, and I think focusing on v4 would be simpler for these :)

I agree that v4 should indeed be the most important target. I tried to change but then also get a lot of other commits... How do I most easily rebase(?)

But I also think it's too nice to not also update for v3. Can't we just cherry-pick the commits in this PR and also merge them in main or v4 too?

@erikvansebille
Copy link
Member Author

erikvansebille commented Apr 3, 2025

There's still something strange going on where the transparent background of the homepage animation is not rendered correctly in dark mode. Not sure if this is a markdown issue or a sphinx issue (it also happens when I sphinx-build locally)? I can't really find a solution online....

Screenshot 2025-04-03 at 10 50 23

@VeckoTheGecko
Copy link
Contributor

can't really find a solution online....

Looks to be pydata/pydata-sphinx-theme#918 ?

If you check out https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html#images-and-content-that-work-in-both-themes ?

We might need to update our version of the theme. Will check

Following suggestion in #1954 (comment)
@erikvansebille erikvansebille merged commit 86947f1 into main Apr 3, 2025
16 checks passed
@erikvansebille erikvansebille deleted the update_dark_docs branch April 3, 2025 10:54
@github-project-automation github-project-automation bot moved this from Backlog to Done in Parcels development Apr 3, 2025
erikvansebille added a commit that referenced this pull request Apr 3, 2025
Following suggestion in #1954 (comment)
@erikvansebille erikvansebille mentioned this pull request Apr 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants