Merged
Conversation
Closed
as not needed now that JIT is removed
Contributor
|
We can drop |
All other uses of cgen were already gone
Contributor
|
@erikvansebille I want to push some edits related to this. Should I create a new PR or push to this one? Mainly todo comments and variable naming for the timebeing |
VeckoTheGecko
approved these changes
Feb 18, 2025
Member
Author
|
Any idea why Windows CI is failing now that |
Contributor
|
@erikvansebille I think its unrelated, there is some flakiness with the windows run where it fails on configuration of the pagefile. Safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bundles some last assorted cleanups of JIT and its references in the code, in preparation for Parcels v4
Fixes #1847