Small refactors of VectorField and pragma comments#1836
Merged
VeckoTheGecko merged 6 commits intomainfrom Feb 3, 2025
Merged
Conversation
Also deprecate old methods temp
used the following regex: def .*\(particle, fieldset, time\):$ test
VeckoTheGecko
force-pushed
the
v/refactor-vector
branch
from
b2b9239 to
dc912ac
Compare
Contributor
Author
|
CI failure looks to be related to xarray. Investigating now... |
Contributor
Author
|
So the failure is related to the recent release of v2025 of xarray. Not sure exactly why, or whether it is a bug with upstream. Loading the zarr dataset explicitly fixes it |
Member
Glad you found it! |
VeckoTheGecko
force-pushed
the
v/refactor-vector
branch
from
ffea461 to
21a7b37
Compare
erikvansebille
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shifting a couple functions out of the VectorField class (as they're independent of the VectorField class).
Also disabled coverage for kernels (the way we use kernels both in JIT and SciPy means that the coverage checker cant detect their usage).