-
Notifications
You must be signed in to change notification settings - Fork 168
Towards a noarch environment file for developer installation #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To test if this doesn't break CI
Because mpi4py doesn't exist for windows
environment.yml
Outdated
| - mpi4py>=3.0.1 # [unix] | ||
| - mpich>=3.2.1 # [unix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are exactly the issue; they are needed for MPI support (which many developers want/use); but not available for Windows.
The alternative is that we don't add these two packages at all; and then ask users to install them manually if they want to run MPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I finally understood your issue. You cannot move to a single arch environment for dev.
- For end users, you can just list parcels and things will just work (no need to list specific parcels deps)
- For dev users, you will need to get them the parcel deps correctly ahead of time, and for that you need separate files because of issues surrounding compilers and MPI
| dependencies: | ||
| - python>=3.8 | ||
| - cgen | ||
| - clang_osx-64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you only needed to change this to c-compiler for this file to work for both osx64 and osx-arm64
| @@ -6,9 +6,6 @@ dependencies: | |||
| - cgen | |||
| - ffmpeg>=3.2.3 | |||
| - git | |||
| - gcc_linux-64 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, remove this regardless. Can use c-compiler instead for flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that this env can in theory work for linux-aarch64 and linux-ppc64
| - mpi4py>=3.0.1 | ||
| - mpich>=3.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never used this feature, but you can try using the mamba selectors like commented in the other issue
As suggested in #1299 (comment)
For consistency throughout parcels
This reverts commit 6a79065.
This reverts commit a78c2b9.
This reverts commit cd2a980.
for more information, see https://pre-commit.ci
This reverts commit a3c45d8.
Following the discussion in #1299 (comment), this PR attempts to move Parcels to one 'noarch' environment file without a different compiler for each architecture
Steps to take
environment.yml(so also droppingpy3part)