-
Notifications
You must be signed in to change notification settings - Fork 168
Allow for Zarr stores being passed to ParticleFile #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Zarr stores being passed to ParticleFile #1303
Conversation
This reverts commit 161f426.
|
Thanks for this PR, @willirath, it looks very good! Apart from the small change proposed above on the MPI-handling, my only comment would be to rename the Also, I'm pinging @JamiePringle, so he can have a quick look at this new feature too |
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
|
@erikvansebille I've renamed to notebook as suggested and also fixed the MPI check. Re this also being a possible integration test: I think it wouldn't hurt as it also does not rely on any input data (but produces some output) and is relatively quick (30 seconds in total?). But seeing the already substantial time spent on automated tests, I can also see that it makes sense not to run everything. |
Let's allow for directly passing a
zarr.storage.Storeobject toParticleFile. This will allow for a couple of advanced output strategies:MemoryStoreRedisStorecapturing output in a zip file using a(Possible but inefficient and throwing lots of warnings.)ZipZtoreTodos:
ParticleFileworks for Zarr stores directly.