Repository navigation
Fix uv all-extras dependency resolution - #201
Open
ParamThakkar123 wants to merge 1 commit into
Open
ParamThakkar123 wants to merge 1 commit into
ParamThakkar123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
torchwm[all]caused bymlagents-envspulling incompatible NumPy ranges.uvto parse and use the existing lockfile by fixing mismatched package version headers that prevented lock parsing.Description
ml-agentsextra inpyproject.tomltomlagents-envs>=0.28.0,<0.29.0to keep it compatible with the projectnumpy>=1.26.0requirement.pyproject.toml:python-multipart->>=0.0.22,starlette->>=0.52.1,gitpython->>=3.1.46, andmistune->>=3.2.0so they match the versions represented in the lockfile.uv.lockpackageversionheaders and related metadata to match artifact filenames (notablygitpython,idna,mistune,pillow,python-dotenv,python-multipart,starlette,urllib3) and updated theml-agentsmetadata specifier to>=0.28.0,<0.29.0so the lockfile parses cleanly and is consistent with the declared constraints.Testing
python - <<'PY' ... PY) that verifiedpyproject.tomlanduv.lockparse and that lockfile package versions match artifact filenames (passed).git diff --checkto confirm no whitespace/conflict markers (passed).uv sync --all-extras --locked --dry-runanduv sync --all-extras --locked --dry-run --no-build-isolation; both progressed past lock parsing but ultimately failed in this environment due to network/tunnel errors and a missing localsetuptoolsrespectively (environmental failures, not changeset regressions).Codex Task