Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the required resource providers #4

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

zammitjohn
Copy link
Collaborator

Changes

  • Added Resource Provider registration. Re-running this command on the same subscription is not destructive, it will simply re-register the Resource Provider. This adds new locations (if any) that have been added since the previous registration.
    From docs: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-providers-and-types.
  • Switched steps to grant admin consent before KV creation. This was necessary because if the Key Vault creation failed (for example, due to a name conflict), the admin consent would not be given automatically and would have to be done manually later.

@zammitjohn zammitjohn self-assigned this Jan 29, 2024
@mplette mplette merged commit a97ee0d into main Jan 29, 2024
Copy link
Collaborator

@mplette mplette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@zammitjohn zammitjohn deleted the feature/prereqs-azure-provider-registration branch February 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants