DOC: Specify return type of sftp.open() function #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, Thank you for the interest and PR! Left a comment. |
pkittenis
requested changes
Aug 20, 2022
There was a problem hiding this comment.
Please update cython generated code by installing dependencies with pip install -U -r requirements_dev.txt and running pip install -e ..
This will re-generate session.c from the session.pyx source. Changes to session.c should be committed as part of this PR.
See also Cython code section of contributing guide.
|
Hey @pkittenis! Does this look good? |
pkittenis
approved these changes
Aug 23, 2022
|
Looks good, thank you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey devs, thank you for creating this library. I went through the docs and found that the
sftp.open()docs do not specify its return type. I made this simple PR. If you think it would help, you can merge it.