Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added increment to level status #504

Merged

Conversation

brownbaerchen
Copy link
Contributor

This is needed for declaring convergence based on the increment when using the polynomial based error estimate, which writes the error estimate to level.status.error_embedded_estimate, just like the increment based error estimate.
In $\Delta t$-$k$-adaptivity with RBC, I use a stopping criterion that uses both residual and increment, so I need both the error estimate and the increment.
This PR should be seen as a bugfix. Previous tests for CheckConvergence are still valid.

@pancetta pancetta merged commit bf940bd into Parallel-in-Time:master Nov 14, 2024
82 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants