Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] Org mode #2081

Closed
tecosaur opened this issue Feb 24, 2020 · 8 comments
Closed

[Icon request] Org mode #2081

tecosaur opened this issue Feb 24, 2020 · 8 comments

Comments

@tecosaur
Copy link

tecosaur commented Feb 24, 2020

@SmartFinn
Copy link
Member

I didn't find XML file that provides the mime type in https://github.com/bzg/org-mode

Could you post the output of the following command to make sure that mime-type is registered on your system:

gio info -a standard::icon PATH/TO/FILE.org

@tecosaur
Copy link
Author

Running gio info -a standard::icon PATH/TO/FILE.org I get

attributes:
  standard::icon: text-plain, text-x-generic, text-plain-symbolic, text-x-generic-symbolic

Which I imagine means that there isn't a mime type for it by default.

To provide a mime type I imagine

<?xml version="1.0" encoding="UTF-8"?>
<mime-info xmlns='http://www.freedesktop.org/standards/shared-mime-info'>
<mime-type type="text/x-orgmode">
<comment>Org-mode File</comment>
<glob pattern="*.org"/>
<alias type="text/x-orgmode"/>
</mime-type>
</mime-info>

would work however I'm not sure if this is something that papirus does ¯\(ツ)

@SmartFinn
Copy link
Member

SmartFinn commented Feb 24, 2020

Hmm,

https://orgmode.org says

The de facto mimetype for org attachments is text/org.

So, icon name/mimetype should be text-org not text-x-orgmode.

@tecosaur
Copy link
Author

Oh I see, oops. Thanks for catching that.

@tecosaur
Copy link
Author

Oh, as an aside: other than visual nicety I'd find this particularly helpful as .org files can be exported to a wide range of formats, and result in a large number of files being produced. Not having a distinct icon makes it hard to identify the 'source' .org file in many cases, e.g.

image

In the above screenshot, the circled .org file is responsible for all of the files seen, yet it is hard to identify.

@tecosaur
Copy link
Author

@SmartFinn any thoughts?

@SmartFinn
Copy link
Member

@tecosaur sorry, my skills don't let me implement this. Please wait until someone of our authors has time for it.

varlesh added a commit that referenced this issue Mar 1, 2020
@varlesh varlesh closed this as completed Mar 1, 2020
@tecosaur
Copy link
Author

tecosaur commented Mar 1, 2020

@varlesh thanks, it looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants