Skip to content

Conversation

@GliczDev
Copy link
Contributor

simplifies getting the actual number value from a number tag instead of doing a switch statement

@kezz
Copy link
Member

kezz commented Mar 11, 2025

See the build failures

@GliczDev
Copy link
Contributor Author

should be fixed

Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@GliczDev GliczDev force-pushed the numberbinarytag-numbervalue branch from 2d9039a to 33c0bb9 Compare March 13, 2025 15:50
@GliczDev GliczDev requested a review from kezz March 13, 2025 15:51
@kezz kezz added this to the 4.21.0 milestone Apr 11, 2025
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GliczDev
Copy link
Contributor Author

I updated the version in @since tag according to the milestone :)

@zml2008 zml2008 self-assigned this Apr 13, 2025
@zml2008 zml2008 added this pull request to the merge queue Apr 13, 2025
Merged via the queue into PaperMC:main/4 with commit 3c1be46 Apr 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants